We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4582 - Window10 Maximized windows is bad
Summary: Window10 Maximized windows is bad
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: *don't know* (show other bugs)
Version: don't know
Hardware: All Windows 10
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-06 21:22 UTC by Sylvain
Modified: 2019-04-08 11:45 UTC (History)
0 users

See Also:

Attachments
testcase (3.92 KB, text/x-csrc)
2019-04-07 12:11 UTC, Sylvain 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sylvain 2019-04-06 21:22:33 UTC 
On window10 desktop, I have a resizeable window.
When I click the upper-right maximized button, it gets maximized.

I don't use the hint letterbox/overscan. (it goes into scale_policy == 0)

There are the vertical black bars added to the left and right, which is correct.
The aspect ratio seems ok.
It must be zoomed a little bit.
But it is zoomed too much so the app isn't drawn on the right, nor on the bottom.


Before it was ok. I mean the previous builds, so it's not an update of win10.
Comment 1 Sylvain 2019-04-07 12:11:07 UTC 
Created attachment 3736 [details]
testcase

here's a testcase, when it gets maximized on window 10 with latest hg.
all corners, except upper left, disappears.

It's working fine on linux and was working previously.
Comment 2 Sylvain 2019-04-07 12:14:18 UTC 
also, when you resize the window manually, and so that it's smaller, you have something which is not letterbox nor overscan.
there are strips left/right and bottom.

on linux, this is ok: 
either left and right, or bottom and top.
Comment 3 Sylvain 2019-04-07 13:43:26 UTC 
It seems to be broken since the new renderer batching, it would be nice to fix it ! Thanks
Comment 4 Sylvain 2019-04-07 16:48:18 UTC 
it seems we update 'vertexShaderConstantsData.projectionAndView'

 https://hg.libsdl.org/SDL/file/0cc2592ed0f4/src/render/direct3d11/SDL_render_d3d11.c#l1938

but we don't call ID3D11DeviceContext_UpdateSubresource

https://hg.libsdl.org/SDL/file/0cc2592ed0f4/src/render/direct3d11/SDL_render_d3d11.c#l2076

If the previous one is called, this resolves the issue
Comment 5 Sylvain 2019-04-08 11:45:17 UTC 
Fixed in https://hg.libsdl.org/SDL/rev/c6356921b02b