We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4544 - SDL2.m4 SDL2.framework patch made it impossible to fail detection
Summary: SDL2.m4 SDL2.framework patch made it impossible to fail detection
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: build (show other bugs)
Version: HG 2.1
Hardware: All All
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-11 22:04 UTC by Stian Skjelstad
Modified: 2019-03-17 01:45 UTC (History)
0 users

See Also:

Attachments
check if $sdl_framework is set, before checking if directory exists (488 bytes, patch)
2019-03-11 22:04 UTC, Stian Skjelstad 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stian Skjelstad 2019-03-11 22:04:50 UTC 
Created attachment 3693 [details]
check if $sdl_framework is set, before checking if directory exists

Patch that was merged here https://hg.libsdl.org/SDL/rev/9befd0acb9ef made it impossible for the SDL2 detection to fail, since one of the if statements fails to check if a variable is set or not.

if test -d $sdl_framework; then

can evaluate to true in some shells. I guess it falls into undefined behaviour when looking at the POSIX standard.
Comment 1 Sam Lantinga 2019-03-17 01:45:32 UTC 
Fixed, thanks!
https://hg.libsdl.org/SDL/rev/fa75f0fb9e96