This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

• check if $sdl_framework is set, before checking if directory exists (sdl2.m4.patch, text/plain, 2019-03-11 22:04:50 +0000, 488 bytes)

Reported in version: HG 2.1
Reported for operating system, platform: All, All

Comments on the original bug report:

On 2019-03-11 22:04:50 +0000, Stian Skjelstad wrote:

Created attachment 3693
check if $sdl_framework is set, before checking if directory exists

Patch that was merged here https://hg.libsdl.org/SDL/rev/9befd0acb9ef made it impossible for the SDL2 detection to fail, since one of the if statements fails to check if a variable is set or not.

if test -d $sdl_framework; then

can evaluate to true in some shells. I guess it falls into undefined behaviour when looking at the POSIX standard.

On 2019-03-17 01:45:32 +0000, Sam Lantinga wrote:

Fixed, thanks!
https://hg.libsdl.org/SDL/rev/fa75f0fb9e96