We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4521 - [PATCH] wayland: HiDPI support
Summary: [PATCH] wayland: HiDPI support
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: video (show other bugs)
Version: HG 2.0
Hardware: All Linux
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-24 03:33 UTC by Sebastian Krzyszkowiak
Modified: 2019-06-12 14:44 UTC (History)
1 user (show)

See Also:

Attachments
0001-wayland-HiDPI-support.patch (16.62 KB, patch)
2019-02-24 03:33 UTC, Sebastian Krzyszkowiak 		Details | Diff
wayland: HiDPI support (16.96 KB, patch)
2019-06-11 23:11 UTC, Sebastian Krzyszkowiak 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Krzyszkowiak 2019-02-24 03:33:21 UTC 
Created attachment 3655 [details]
0001-wayland-HiDPI-support.patch

Implemented hidpi support on the Wayland platform.
Comment 1 Ryan C. Gordon 2019-05-18 18:48:54 UTC 
Tagging a bunch of bugs with "target-2.0.10" so we have a clear list of things to address before a 2.0.10 release.

Please note that "addressing" one of these bugs might mean deciding to defer on it until after 2.0.10, or resolving it as WONTFIX, etc. This is just here to tell us we should look at it carefully, and soon.

If you have new information or feedback on this issue, this is a good time to add it to the conversation, as we're likely to be paying attention to this specific report in the next few days/weeks.

Thanks!

--ryan.
Comment 2 Sam Lantinga 2019-06-09 00:44:37 UTC 
We need to revisit how high DPI support works in SDL.
Comment 3 Harry Jeffery 2019-06-11 22:19:27 UTC 
I didn't see this first, so I came up with a similar patch myself. I've tested  Sebastian's patch on wayland with the sway compositor (though only single-monitor) and it worked as I expected it to.

I'm hoping to see this included in the next release
Comment 4 Sebastian Krzyszkowiak 2019-06-11 22:46:25 UTC 
It's especially important to have it supported rather sooner than later given that the devices devices that rely on Wayland and hidpi scaling, such as Librem 5 and PinePhone smartphones, are soon to be released.
Comment 5 Sebastian Krzyszkowiak 2019-06-11 23:11:17 UTC 
Created attachment 3820 [details]
wayland: HiDPI support

Updated the patch to apply cleanly on the current tip and to include Vulkan support, which I forgot about earlier.
Comment 6 Sam Lantinga 2019-06-12 14:44:23 UTC 
Okay, patch reviewed and added:
https://hg.libsdl.org/SDL/rev/d92b5fbb5ac0

Thanks!