We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4512 - [PATCH] emscripten: force resize event when pixel ratio changes
Summary: [PATCH] emscripten: force resize event when pixel ratio changes
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: video (show other bugs)
Version: HG 2.0
Hardware: All Other
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-20 02:23 UTC by Sebastian Krzyszkowiak
Modified: 2019-03-17 02:09 UTC (History)
0 users

See Also:

Attachments
0001-emscripten-force-resize-event-when-pixel-ratio-chang.patch (1.08 KB, patch)
2019-02-20 02:23 UTC, Sebastian Krzyszkowiak 		Details | Diff
0001-emscripten-force-resize-event-when-pixel-ratio-chang.patch (1.78 KB, patch)
2019-02-24 03:44 UTC, Sebastian Krzyszkowiak 		Details | Diff
0001-emscripten-force-resize-event-when-pixel-ratio-chang.patch (1.78 KB, patch)
2019-02-24 04:01 UTC, Sebastian Krzyszkowiak 		Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Krzyszkowiak 2019-02-20 02:23:18 UTC 
Created attachment 3638 [details]
0001-emscripten-force-resize-event-when-pixel-ratio-chang.patch

Without this, applications can't react to changed canvas size on window zoom.
Comment 1 Sebastian Krzyszkowiak 2019-02-24 03:44:04 UTC 
Created attachment 3656 [details]
0001-emscripten-force-resize-event-when-pixel-ratio-chang.patch

Updated to force only when pixel ratio has changed.

https://github.com/emscripten-ports/SDL2/pull/76
Comment 2 Sebastian Krzyszkowiak 2019-02-24 04:01:23 UTC 
Created attachment 3657 [details]
0001-emscripten-force-resize-event-when-pixel-ratio-chang.patch
Comment 3 Sam Lantinga 2019-03-17 02:09:24 UTC 
Patch added, thanks!
https://hg.libsdl.org/SDL/rev/b3c652757f97