This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

• Fix Linux periodic rumble support (flibitIsBad.patch, text/plain, 2018-12-06 19:27:29 +0000, 1120 bytes)

Reported in version: 2.0.9
Reported for operating system, platform: Linux, x86_64

Comments on the original bug report:

On 2018-12-06 15:40:11 +0000, wrote:

I noticed rumble was broken with my official Sony dualshock3 controller in programs like sdl2-jstest and mupen64plus while using SDL-2.0.9 and the master, but not with 2.0.8.

So I bisected the issue and the first bad commit is 44a639b5f1af.

http://hg.libsdl.org/SDL/rev/44a639b5f1af

This can be reproduced with:

sdl2-jstest --rumble 0

Is there any more information I can provide?

On 2018-12-06 15:44:12 +0000, wrote:

Also links to the affected projects, this issue was reproduced with the current git master for both of them.

https://gitlab.com/sdl-jstest/sdl-jstest
https://github.com/mupen64plus/mupen64plus-input-sdl

On 2018-12-06 19:03:57 +0000, wrote:

testrumble still works.

INFO: 1 Haptic devices detected.
INFO: Device: Sony PLAYSTATION(R)3 Controller
INFO: Playing 2 second rumble at 0.5 magnitude.
INFO: Stopping rumble.
INFO: Playing 2 second rumble at 0.3 magnitude

testjoystick prints.

INFO: There are 1 joysticks attached
INFO: Joystick 0: Sony PLAYSTATION(R)3 Controller
INFO: type: Game Controller
INFO: axes: 6
INFO: balls: 0
INFO: hats: 0
INFO: buttons: 17
INFO: instance id: 0
INFO: guid: 030000004c0500006802000011810000
INFO: VID/PID: 0x054c/0x0268

On 2018-12-06 19:15:47 +0000, Sam Lantinga wrote:

Ethan, can you take a look at this?

Thanks!

On 2018-12-06 19:27:29 +0000, Ethan Lee wrote:

Created attachment 3533
Fix Linux periodic rumble support

Dangit, even Linux wasn't consistent here - left/right is u16 but periodic is s16. I only have left/right devices so I didn't catch this at the time. Patch is attached.

On 2018-12-06 19:42:34 +0000, wrote:

I tested the attached patch against master and rumble works with both my test cases again, thanks!

On 2018-12-08 19:25:32 +0000, Sam Lantinga wrote:

Thanks!
https://hg.libsdl.org/SDL/rev/1f8d0b1afe07

On 2018-12-08 19:25:59 +0000, Sam Lantinga wrote:

This is now fixed.

On 2018-12-08 19:50:13 +0000, wrote:

Thank you for the quick fix!