We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4412 - Misplaced and mistyped WORKING_DIR parameter in install(execute_process()) in CMakeLists.txt
Summary: Misplaced and mistyped WORKING_DIR parameter in install(execute_process()) in...
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: build (show other bugs)
Version: don't know
Hardware: x86_64 Linux
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords: target-2.0.10
Depends on:
Blocks:
 
Reported: 2018-12-03 18:28 UTC by Serhii Charykov
Modified: 2019-05-19 18:54 UTC (History)
1 user (show)

See Also:

Attachments
Patch (945 bytes, patch)
2018-12-03 18:28 UTC, Serhii Charykov 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Serhii Charykov 2018-12-03 18:28:22 UTC 
Created attachment 3523 [details]
Patch

As far as I can tell there is a misplaced closing ")" in file CMakeLists.txt near line 1860:
 install(CODE "
   execute_process(COMMAND ${CMAKE_COMMAND} -E create_symlink
     \"lib${SONAME}${SOPOSTFIX}${SOEXT}\" \"libSDL2${SOPOSTFIX}${SOEXT}\")"
     WORKING_DIR "${SDL2_BINARY_DIR}")

According to:

https://cmake.org/cmake/help/v3.0/command/execute_process.html
https://cmake.org/cmake/help/v3.0/command/install.html

WORKING_DIR exists only as parameter in execute_process command.

And in documentation it is "WORKING_DIRECTORY".
Comment 1 Ryan C. Gordon 2019-05-18 18:48:54 UTC 
Tagging a bunch of bugs with "target-2.0.10" so we have a clear list of things to address before a 2.0.10 release.

Please note that "addressing" one of these bugs might mean deciding to defer on it until after 2.0.10, or resolving it as WONTFIX, etc. This is just here to tell us we should look at it carefully, and soon.

If you have new information or feedback on this issue, this is a good time to add it to the conversation, as we're likely to be paying attention to this specific report in the next few days/weeks.

Thanks!

--ryan.
Comment 2 Sam Lantinga 2019-05-19 18:54:18 UTC 
Patch added, thanks!
https://hg.libsdl.org/SDL/rev/b7320ef610b5