Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-processor __ARM_NEON detection on arm64 #3089

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 0 comments
Closed

Pre-processor __ARM_NEON detection on arm64 #3089

SDLBugzilla opened this issue Feb 11, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: don't know
Reported for operating system, platform: Android (All), ARM

Comments on the original bug report:

On 2018-12-03 08:51:32 +0000, Sylvain wrote:

(at least) on Android ndk-r18:

if you compile with arm64-v8a, ARM_NEON isn't defined (so SDL2 doesn't include "<arm_neon.h>"), but __ARM_NEON is.

on arm-v7a, if you enable neon with Android.mk, both get defined.

https://patchwork.ozlabs.org/patch/434847/
Seems that ARM_NEON is legacy and we should use __ARM_NEON

On 2018-12-03 08:54:08 +0000, Sylvain wrote:

Created attachment 3518
patch

patch

On 2018-12-04 11:40:29 +0000, Sylvain wrote:

Fixed in http://hg.libsdl.org/SDL/rev/17cb4ff70507

On 2018-12-04 15:55:19 +0000, Sylvain wrote:

Marked as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant