Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failed detection SDL_HasNEON() #3086

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 0 comments
Closed

failed detection SDL_HasNEON() #3086

SDLBugzilla opened this issue Feb 11, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: don't know
Reported for operating system, platform: Android (All), ARM

Comments on the original bug report:

On 2018-12-01 13:41:54 +0000, Sylvain wrote:

When compiling with armeabi-v7a, SDL_HasNEON() doesn't detect NEON.

In this mode, it uses "readProcAuxvForNeon()" which reads "/proc/self/auxv".
But this is sometimes not accessible.

in ndk cpufeatures it says:

// Parsing /proc/self/auxv will fail from regular application
// processes on some Android platform versions, when this happens
// parse proc/cpuinfo instead.

We should use cpufeatures that also reads /proc/cpuinfo

On 2018-12-01 13:47:25 +0000, Sylvain wrote:

Created attachment 3517
patch

Patch that uses cpu-features.

  • I am not 100% sure of the Android.mk (Mine is a little bit different).

  • it also fix a comment missing in blendmode.h (-Wdocumentation)

On 2018-12-01 17:20:24 +0000, Ryan C. Gordon wrote:

Patch that uses cpu-features.

This is now https://hg.libsdl.org/SDL/rev/3a0793e5e134

( and the blendmode doxygen comment in that patch is https://hg.libsdl.org/SDL/rev/a107bc9988d1 )

Thanks!

--ryan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant