Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL2 compilation fails with --enable-video-directfb #3085

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 0 comments
Closed

SDL2 compilation fails with --enable-video-directfb #3085

SDLBugzilla opened this issue Feb 11, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

Reported in version: 2.0.9
Reported for operating system, platform: Linux, x86_64

Comments on the original bug report:

On 2018-12-01 02:35:12 +0000, Gilberto wrote:

Different errors from already reported bugs. Configured with --enable-video-directfb flag produces the following errors when running make:

/home/home_user/repos/SDL/src/video/directfb/SDL_DirectFB_render.c: In function 'DirectFB_CreateRenderer':
/home/home_user/repos/SDL/src/video/directfb/SDL_DirectFB_render.c:372:13: error: 'SDL_Renderer {aka struct SDL_Renderer}' has no member named 'SetTextureAlphaMod'
renderer->SetTextureAlphaMod = DirectFB_SetTextureAlphaMod;
^~
/home/home_user/repos/SDL/src/video/directfb/SDL_DirectFB_render.c:373:13: error: 'SDL_Renderer {aka struct SDL_Renderer}' has no member named 'SetTextureColorMod'
renderer->SetTextureColorMod = DirectFB_SetTextureColorMod;
^~
/home/home_user/repos/SDL/src/video/directfb/SDL_DirectFB_render.c:374:13: error: 'SDL_Renderer {aka struct SDL_Renderer}' has no member named 'SetTextureBlendMode'; did you mean 'SupportsBlendMode'?
renderer->SetTextureBlendMode = DirectFB_SetTextureBlendMode;
^~
/home/home_user/repos/SDL/src/video/directfb/SDL_DirectFB_render.c:377:13: error: 'SDL_Renderer {aka struct SDL_Renderer}' has no member named 'RenderClear'; did you mean 'RenderPresent'?
renderer->RenderClear = DirectFB_RenderClear;
^~
/home/home_user/repos/SDL/src/video/directfb/SDL_DirectFB_render.c:379:13: error: 'SDL_Renderer {aka struct SDL_Renderer}' has no member named 'RenderDrawPoints'; did you mean 'QueueDrawPoints'?
renderer->RenderDrawPoints = DirectFB_RenderDrawPoints;
^~
/home/home_user/repos/SDL/src/video/directfb/SDL_DirectFB_render.c:380:13: error: 'SDL_Renderer {aka struct SDL_Renderer}' has no member named 'RenderDrawLines'; did you mean 'QueueDrawLines'?
renderer->RenderDrawLines = DirectFB_RenderDrawLines;
^~
/home/home_user/repos/SDL/src/video/directfb/SDL_DirectFB_render.c:382:13: error: 'SDL_Renderer {aka struct SDL_Renderer}' has no member named 'RenderFillRects'; did you mean 'QueueFillRects'?
renderer->RenderFillRects = DirectFB_RenderFillRects;
^~
/home/home_user/repos/SDL/src/video/directfb/SDL_DirectFB_render.c:384:13: error: 'SDL_Renderer {aka struct SDL_Renderer}' has no member named 'RenderCopy'; did you mean 'QueueCopy'?
renderer->RenderCopy = DirectFB_RenderCopy;
^~
/home/home_user/repos/SDL/src/video/directfb/SDL_DirectFB_render.c:393:13: error: 'SDL_Renderer {aka struct SDL_Renderer}' has no member named 'UpdateViewport'; did you mean 'UpdateTexture'?
renderer->UpdateViewport = DirectFB_UpdateViewport;
^~
/home/home_user/repos/SDL/src/video/directfb/SDL_DirectFB_render.c:394:13: error: 'SDL_Renderer {aka struct SDL_Renderer}' has no member named 'UpdateClipRect'
renderer->UpdateClipRect = DirectFB_UpdateClipRect;

On 2018-12-01 02:37:11 +0000, Gilberto wrote:

Additional information (not sure if this is helpful): Latest change set is 12435:261716de5769

On 2018-12-01 18:10:46 +0000, Ryan C. Gordon wrote:

Ugh, I didn't realize there was a render backend in the video directory. I wonder how that happened. :/

I'll take a look, and maybe also move it to the right place.

--ryan.

On 2018-12-02 07:37:48 +0000, Ryan C. Gordon wrote:

This is patched to compile again in https://hg.libsdl.org/SDL/rev/695bf801d4ba, but I don't know if it actually works. testsprite2 gets about 600 fps on this laptop with the directfb renderer now, but I don't get a window or anything; presumably it's on another virtual terminal writing to /dev/fb0 or something.

Please reopen this bug if you run into trouble with it.

--ryan.

On 2018-12-02 17:17:39 +0000, Gilberto wrote:

Hello again,

I got the following error:

/home/home_user/repos/SDL/src/video/directfb/SDL_DirectFB_video.c:327:7: error: 'DSPF_ABGR' undeclared here (not in a function)
{ DSPF_ABGR, SDL_PIXELFORMAT_ABGR8888 }, /* 32 bit ABGR (4 byte, alpha 8@24, blue 8@16, green 8@8, red 8@0) */

However, after commenting it out (I'm not aware of the implications of doing so), compilation ended with a single warning. I was able to make install, same for the tests and I successfully executed ./testdraw2 from tty1.

Thanks a lot Ryan.

On 2018-12-03 06:32:05 +0000, Ozkan Sezer wrote:

(In reply to Gilberto from comment # 4)

Hello again,

I got the following error:

/home/home_user/repos/SDL/src/video/directfb/SDL_DirectFB_video.c:327:7:
error: 'DSPF_ABGR' undeclared here (not in a function)
{ DSPF_ABGR, SDL_PIXELFORMAT_ABGR8888 }, /* 32 bit ABGR (4
byte, alpha 8@24, blue 8@16, green 8@8, red 8@0) */

AFAIK, DSPF_ABGR is added in directfb-1.5.0: make sure that you are
building against directfb >= 1.5.0 ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant