We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4383 - Small issue with face style
Summary: Small issue with face style
Status: RESOLVED FIXED
Alias: None
Product: SDL_ttf
Classification: Unclassified
Component: misc (show other bugs)
Version: unspecified
Hardware: x86_64 Linux
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-14 10:34 UTC by Sylvain
Modified: 2018-12-18 08:44 UTC (History)
0 users

See Also:

Attachments
patch (2.82 KB, patch)
2018-11-14 10:34 UTC, Sylvain 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sylvain 2018-11-14 10:34:01 UTC 
If you request the font style the first time, you won't get the potential style of the font.

I've introduce this here by moving code, font->style is initialized before font->face_style.
https://hg.libsdl.org/SDL_ttf/rev/ff81ac6d76c4

Here's a clean-up also to lighten patch of bug 4361.

so that:
- face_style is removed from TTF_Font structure
- macro, at runtime, are smaller
- face_style is added/removed by TTF_Get/SetFontSyle().
Comment 1 Sylvain 2018-11-14 10:34:55 UTC 
Created attachment 3491 [details]
patch
Comment 2 Sylvain 2018-12-18 08:44:00 UTC 
Fixed in https://hg.libsdl.org/SDL_ttf/rev/758230d133f7