Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.9 fails to build against OS X 10.7 SDK #3059

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 0 comments
Closed

2.0.9 fails to build against OS X 10.7 SDK #3059

SDLBugzilla opened this issue Feb 11, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: 2.0.9
Reported for operating system, platform: Mac OS X 10.7, All

Comments on the original bug report:

On 2018-11-08 06:27:09 +0000, Joshua Root wrote:

Created attachment 3463
patch to limit use of CGColor property to 10.8+

SDL2-2.0.9/src/video/cocoa/SDL_cocoawindow.m:1178:53: error: property 'CGColor' not found on object of type 'NSColor *'
self.layer.backgroundColor = NSColor.blackColor.CGColor;
^

Fix seems pretty simple.

On 2018-11-09 17:43:31 +0000, Riccardo Mottola wrote:

I propose the new patch, which is valid for all systems, does not depend on a 10.8 specific function and is also faster because it uses a constant of CG instead of going through NS

On 2018-11-09 17:43:51 +0000, Riccardo Mottola wrote:

Created attachment 3482
allocate Black constant CGColor directly

On 2018-11-11 00:57:51 +0000, Alex Szpakowski wrote:

Thanks for the patch! It's been applied here: https://hg.libsdl.org/SDL/rev/5a95fbfd3617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant