We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4354 - CMake builds do not correctly enable IME on Linux
Summary: CMake builds do not correctly enable IME on Linux
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: build (show other bugs)
Version: 2.0.9
Hardware: x86_64 Linux
: P2 major
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords: target-2.0.14
Depends on:
Blocks:
 
Reported: 2018-11-03 15:54 UTC by Callum McGing
Modified: 2020-06-28 17:56 UTC (History)
1 user (show)

See Also:

Attachments
Patch to enable SDL_USE_IME when ibus is detected (430 bytes, patch)
2018-11-03 15:54 UTC, Callum McGing 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Callum McGing 2018-11-03 15:54:28 UTC 
Created attachment 3439 [details]
Patch to enable SDL_USE_IME when ibus is detected

While the CMake build checks for ibus and does enable the ibus backend with set(HAVE_IBUS_IBUS_H TRUE), this does not define SDL_USE_IME, thus CMake built SDL2 (as in Arch Linux) cannot use IME at all. 

The attached patch fixes this behaviour when building against ibus. IME support will still fail when only fcitx is available on the build system.
Comment 1 Ryan C. Gordon 2019-07-30 17:49:38 UTC 
(Sorry if you get several emails like this, we're marking a bunch of bugs.)

We're hoping to ship SDL 2.0.11 on a much shorter timeframe than we have historically done releases, so I'm starting to tag bugs we hope to have closed in this release cycle.

Note that this tag means we just intend to scrutinize this bug for the 2.0.11 release: we may fix it, reject it, or even push it back to a later release for now, but this helps give us both a goal and a wishlist for the next release.

If this bug has been quiet for a few months and you have new information (such as, "this is definitely still broken" or "this got fixed at some point"), please feel free to retest and/or add more notes to the bug.

--ryan.
Comment 2 Callum McGing 2019-08-03 11:59:17 UTC 
This is still broken in current master
Comment 3 Sam Lantinga 2019-08-06 06:47:24 UTC 
This needs to be reworked to more closely match configure.ac, and fix building with fcitx, but your patch is in:
https://hg.libsdl.org/SDL/rev/1353fb9be62b

Thanks!
Comment 4 Ryan C. Gordon 2019-09-20 20:47:39 UTC 
We're changing how we do SDL release versions; now releases will be even numbers (2.0.10, 2.0.12, etc), and as soon as we tag a release, we'll move the internal version number to an odd number (2.0.12 ships, we tag the latest in revision control as 2.0.13 immediately, which will become 2.0.14 on release, etc).

As such, I'm moving the bugs tagged with target-2.0.11 to target 2.0.12. Sorry if you get a lot of email from this change!

Thanks,
--ryan.
Comment 5 Ryan C. Gordon 2019-09-20 20:48:40 UTC 
We're changing how we do SDL release versions; now releases will be even numbers (2.0.10, 2.0.12, etc), and as soon as we tag a release, we'll move the internal version number to an odd number (2.0.12 ships, we tag the latest in revision control as 2.0.13 immediately, which will become 2.0.14 on release, etc).

As such, I'm moving the bugs tagged with target-2.0.11 to target 2.0.12. Sorry if you get a lot of email from this change!

Thanks,
--ryan.
Comment 6 Ryan C. Gordon 2020-06-28 17:56:58 UTC 
I believe recent changes fixed this for the fcitx-only case, etc.

--ryan.