We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4333 - Enable underline and strike-through styles for the SDL_ttf Wrapped functions
Summary: Enable underline and strike-through styles for the SDL_ttf Wrapped functions
Status: RESOLVED FIXED
Alias: None
Product: SDL_ttf
Classification: Unclassified
Component: misc (show other bugs)
Version: unspecified
Hardware: All All
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-26 09:58 UTC by Sylvain
Modified: 2018-10-30 03:22 UTC (History)
1 user (show)

See Also:

Attachments
patch (3.20 KB, patch)
2018-10-26 10:04 UTC, Sylvain 		Details | Diff
test case (4.58 KB, text/x-csrc)
2018-10-29 11:13 UTC, Sylvain 		Details
screenshot (184.49 KB, image/bmp)
2018-10-29 11:16 UTC, Sylvain 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sylvain 2018-10-26 09:58:05 UTC 
Enable underline and strike-through styles for the SDL_ttf Wrapped functions
Comment 1 Sylvain 2018-10-26 10:04:24 UTC 
Created attachment 3399 [details]
patch

Here's a patch.

It enables both styles and uses the real text/line width, not the whole surface width.

It has to be applied after bug #4266.
Comment 2 Ozkan Sezer 2018-10-27 07:04:28 UTC 
Sam, I won't mess with this one, it's for you.
Comment 3 Sylvain 2018-10-29 11:13:09 UTC 
Created attachment 3411 [details]
test case

adding test case and screenshot
Comment 4 Sylvain 2018-10-29 11:16:42 UTC 
Created attachment 3412 [details]
screenshot

screenshot.

underline and strike-through can be used with the ttf render wrap function.
it's not full width (surface width), but limited to the text line width.
Comment 5 Sam Lantinga 2018-10-30 03:22:56 UTC 
Patch has been added, thanks!
https://hg.libsdl.org/SDL_ttf/rev/b85e8441832e