We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4303 - remove smpeg support completely?
Summary: remove smpeg support completely?
Status: RESOLVED FIXED
Alias: None
Product: SDL_mixer
Classification: Unclassified
Component: misc (show other bugs)
Version: unspecified
Hardware: All All
: P2 normal
Assignee: Ozkan Sezer
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-10 15:28 UTC by Ozkan Sezer
Modified: 2018-10-11 08:55 UTC (History)
0 users

See Also:

Attachments
patch to remove smpeg support (104.95 KB, patch)
2018-10-10 15:28 UTC, Ozkan Sezer 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ozkan Sezer 2018-10-10 15:28:44 UTC 
Created attachment 3359 [details]
patch to remove smpeg support

The smpeg support in current hg needs caring and love, e.g.
SMPEG_Play(void *) should really be SMPEG_Play(void *c, int)
and play_count must be handled somehow.

If noone wants to provide that care & love, I suggest that
we remove smpeg support completely: libmpg123 and libmad are
working fine in its stead.  A patch is attached.

If removal is OK'ed, I can do the same to the 1.2 branch and
port libmpg123 support there easily, too.
Comment 1 Ryan C. Gordon 2018-10-10 17:10:41 UTC 
I say do it. Smpeg has been a dead codebase for 15+ years.
Comment 2 Ozkan Sezer 2018-10-10 18:03:11 UTC 
default 2.0 branch: https://hg.libsdl.org/SDL_mixer/rev/253f50984a9a

Will do the same to 1.2 branch and port mpg123 support to it soon.
Comment 3 Ozkan Sezer 2018-10-11 08:55:09 UTC 
SDL-1.2 branch: https://hg.libsdl.org/SDL_mixer/rev/6c862e733898

Closing.