We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4288 - Support for VK_KHR_mir_surface should be removed or made internal
Summary: Support for VK_KHR_mir_surface should be removed or made internal
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: *don't know* (show other bugs)
Version: don't know
Hardware: x86_64 Linux
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-01 15:41 UTC by Jason Ekstrand
Modified: 2018-11-07 00:58 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Ekstrand 2018-10-01 15:41:35 UTC 
See also https://github.com/KhronosGroup/Vulkan-Docs/issues/814
Comment 1 Sam Lantinga 2018-10-01 16:31:22 UTC 
We don't actually use this extension, it's simply part of the Khronos header we've pulled.

Please let us know when it's been removed from Khronos headers and we'll grab new ones.

Thanks!
Comment 2 programmerjake 2018-10-01 18:14:54 UTC 
(In reply to Sam Lantinga from comment #1)
> We don't actually use this extension, it's simply part of the Khronos header
> we've pulled.
> 
> Please let us know when it's been removed from Khronos headers and we'll
> grab new ones.
> 
> Thanks!

That's incorrect, see https://github.com/spurious/SDL-mirror/blob/d2fcd08e539f879ba1cfe864a5fd310cf8deb72b/src/video/mir/SDL_mirvulkan.c
Comment 3 Sam Lantinga 2018-10-01 21:39:41 UTC 
Oh sorry, you're correct. I think we're also planning to remove the Mir code from SDL.

Ryan, do you know the status of that?
Comment 4 Jason Ekstrand 2018-10-15 15:15:12 UTC 
Any update?  We'd like to move the extension removal process along.  If it's going to take a long time to rip out Mir support, you can carry a version of the headers internally that still contains VK_KHR_mir_surface to keep your code building.
Comment 5 Ryan C. Gordon 2018-10-15 20:27:46 UTC 
(In reply to Sam Lantinga from comment #3)
> Oh sorry, you're correct. I think we're also planning to remove the Mir code
> from SDL.
> 
> Ryan, do you know the status of that?

Last we spoke, the opinion of the Mir developers was: we're moving away from this to turn Mir into a Wayland client, so hold onto this code a little longer.

But honestly? Has anyone outside of the Mir project ever used this, and will anyone _ever_ use this code in SDL? I suspect the answer is no and no.

I say we dump it now, before 2.0.9. I'll yank it today if you agree, Sam.

--ryan.
Comment 6 Sam Lantinga 2018-11-03 00:19:12 UTC 
Let's dump it for 2.0.10.

Thanks!
Comment 7 Ryan C. Gordon 2018-11-03 01:35:04 UTC 
(In reply to Sam Lantinga from comment #6)
> Let's dump it for 2.0.10.
> 
> Thanks!

Now dumped in https://hg.libsdl.org/SDL/rev/ca6e41ade79a

--ryan.
Comment 8 Ryan C. Gordon 2018-11-03 01:36:56 UTC 
> Now dumped in https://hg.libsdl.org/SDL/rev/ca6e41ade79a

Oh, to be clear, this removes the Mir backend from SDL entirely, but the Vulkan headers still have it. But we aren't using this part of the Vulkan headers now, if someone wants to update those.

--ryan.
Comment 9 Brandon Schaefer 2018-11-06 15:45:09 UTC 
+1 from me as well, and thanks for removing!
Comment 10 Jason Ekstrand 2018-11-06 15:45:52 UTC 
FYI, it was removed from the headers in the latest Vulkan spec update.
Comment 11 Sam Lantinga 2018-11-07 00:58:37 UTC 
The SDL Vulkan headers have been updated:
https://hg.libsdl.org/SDL/rev/77433beaf97a