Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for VK_KHR_mir_surface should be removed or made internal #3000

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 0 comments
Closed

Support for VK_KHR_mir_surface should be removed or made internal #3000

SDLBugzilla opened this issue Feb 11, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

Reported in version: don't know
Reported for operating system, platform: Linux, x86_64

Comments on the original bug report:

On 2018-10-01 15:41:35 +0000, Jason Ekstrand wrote:

See also KhronosGroup/Vulkan-Docs#814

On 2018-10-01 16:31:22 +0000, Sam Lantinga wrote:

We don't actually use this extension, it's simply part of the Khronos header we've pulled.

Please let us know when it's been removed from Khronos headers and we'll grab new ones.

Thanks!

On 2018-10-01 18:14:54 +0000, wrote:

(In reply to Sam Lantinga from comment # 1)

We don't actually use this extension, it's simply part of the Khronos header
we've pulled.

Please let us know when it's been removed from Khronos headers and we'll
grab new ones.

Thanks!

That's incorrect, see https://github.com/spurious/SDL-mirror/blob/d2fcd08e539f879ba1cfe864a5fd310cf8deb72b/src/video/mir/SDL_mirvulkan.c

On 2018-10-01 21:39:41 +0000, Sam Lantinga wrote:

Oh sorry, you're correct. I think we're also planning to remove the Mir code from SDL.

Ryan, do you know the status of that?

On 2018-10-15 15:15:12 +0000, Jason Ekstrand wrote:

Any update? We'd like to move the extension removal process along. If it's going to take a long time to rip out Mir support, you can carry a version of the headers internally that still contains VK_KHR_mir_surface to keep your code building.

On 2018-10-15 20:27:46 +0000, Ryan C. Gordon wrote:

(In reply to Sam Lantinga from comment # 3)

Oh sorry, you're correct. I think we're also planning to remove the Mir code
from SDL.

Ryan, do you know the status of that?

Last we spoke, the opinion of the Mir developers was: we're moving away from this to turn Mir into a Wayland client, so hold onto this code a little longer.

But honestly? Has anyone outside of the Mir project ever used this, and will anyone ever use this code in SDL? I suspect the answer is no and no.

I say we dump it now, before 2.0.9. I'll yank it today if you agree, Sam.

--ryan.

On 2018-11-03 00:19:12 +0000, Sam Lantinga wrote:

Let's dump it for 2.0.10.

Thanks!

On 2018-11-03 01:35:04 +0000, Ryan C. Gordon wrote:

(In reply to Sam Lantinga from comment # 6)

Let's dump it for 2.0.10.

Thanks!

Now dumped in https://hg.libsdl.org/SDL/rev/ca6e41ade79a

--ryan.

On 2018-11-03 01:36:56 +0000, Ryan C. Gordon wrote:

Now dumped in https://hg.libsdl.org/SDL/rev/ca6e41ade79a

Oh, to be clear, this removes the Mir backend from SDL entirely, but the Vulkan headers still have it. But we aren't using this part of the Vulkan headers now, if someone wants to update those.

--ryan.

On 2018-11-06 15:45:09 +0000, Brandon Schaefer wrote:

+1 from me as well, and thanks for removing!

On 2018-11-06 15:45:52 +0000, Jason Ekstrand wrote:

FYI, it was removed from the headers in the latest Vulkan spec update.

On 2018-11-07 00:58:37 +0000, Sam Lantinga wrote:

The SDL Vulkan headers have been updated:
https://hg.libsdl.org/SDL/rev/77433beaf97a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant