Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include wayland protocol XML in source tree #2933

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 0 comments
Closed

Include wayland protocol XML in source tree #2933

SDLBugzilla opened this issue Feb 11, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

Reported in version: HG 2.0
Reported for operating system, platform: All, All

Comments on the original bug report:

On 2018-06-25 06:13:03 +0000, Ryan C. Gordon wrote:

(vocab: Wayland "protocols" are sort of like X11 extensions, but they sit in a little glue code in your program that talks to the server on your behalf instead of an external library on the end-user's system doing that work.)

Right now the configure/cmake scripts look for wayland protocol specifications (XML files) on the user's system, and runs them through a tool that generates the appropriate C glue code for SDL to use, but this means you need a system with the latest protocol definitions (that is, a system with the latest Wayland) to build Wayland support at all without failure, even though the thing that gets built can work on any unextended version of Wayland.

Is there any reason these XML files aren't in SDL itself? The glue code it generates is just a basic API that talks to interfaces exposed at runtime, and we already handle those interfaces not existing, so long as the glue code is compiled into SDL.

If we don't want to have the XML in the source tree, we can also take some effort to fix the configure script to deal with missing protocol files and sprinkle #ifdefs around to turn them off, but it seems simpler and cleaner to just always have the functionality available unconditionally.

This hasn't been a big problem so far because we don't focus on Wayland much yet, and our development hasn't been on bleeding edge interfaces, but fixing Bug # 4121 exposes this issue and it will continue to cause issues as Wayland maybe replaces X11 in some nearish future.

--ryan.

On 2018-06-25 16:41:16 +0000, Ryan C. Gordon wrote:

I did this now, in https://hg.libsdl.org/SDL/rev/1a7dec71e8e0

--ryan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant