Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake complains about trailing spaces in sdl2.pc #2877

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 0 comments
Closed

CMake complains about trailing spaces in sdl2.pc #2877

SDLBugzilla opened this issue Feb 11, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: 2.0.8
Reported for operating system, platform: Linux, x86_64

Comments on the original bug report:

On 2018-04-21 08:49:53 +0000, Azamat H. Hackimov wrote:

When you try use SDL2 2.0.8 in CMake project in Linux, it complains about trailing spaces in sdl2.pc:

CMake Error at CMakeLists.txt:147 (add_executable):
Target "TestSimpleMain" links to item "-L/usr/lib64 -lSDL2 " which has
leading or trailing whitespace. This is now an error according to policy
CMP0004.

On 2018-04-21 08:52:13 +0000, Azamat H. Hackimov wrote:

Created attachment 3226
libsdl2-2.0.8-rework-variables.patch

Proposed fix.

On 2018-04-24 04:52:36 +0000, Sam Lantinga wrote:

I don't think Bourne shell supports += on shell variables. Bash does, but the Bourne shell (/bin/sh) doesn't.

On 2018-04-24 04:56:20 +0000, Sam Lantinga wrote:

This should fix it, thanks!
https://hg.libsdl.org/SDL/rev/28be2719184c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant