Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DirectFB renderer cannot be enabled #2859

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 1 comment
Closed

DirectFB renderer cannot be enabled #2859

SDLBugzilla opened this issue Feb 11, 2021 · 1 comment

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

Reported in version: 2.0.8
Reported for operating system, platform: Linux, All

Comments on the original bug report:

On 2018-04-02 06:56:15 +0000, Michael Hamann wrote:

Due to change https://hg.libsdl.org/SDL/rev/d1ce8396c356#l1.22, the DirectFB renderer cannot be enabled anymore. As the change is otherwise totally unrelated, I assume this was not intentional. Fixing this should be trivial by reverting the affected line. This is a regression of 2.0.8 compared to 2.0.7. This breaks osk-sdl (https://github.com/postmarketOS/osk-sdl) and thus booting of postmarketOS (https://postmarketos.org) with full disk encryption.

On 2018-06-12 14:32:11 +0000, Guido wrote:

Could it be that the removal of AC_DEFINE(SDL_VIDEO_RENDER_DIRECTFB, 1, [ ]) in configure.in is to blame for this?

On 2018-06-12 15:15:01 +0000, Michael Hamann wrote:

Yes, I am sorry if this was not clear, this is exactly the line I have linked to. By "reverting the affected line" I mean re-adding that statement. I can confirm that re-adding that statement fixes this problem. I have also submitted a corresponding patch to Alpine Linux (alpinelinux/aports#3889) with this fix that has been merged and successfully tested by other people from postmarketOS. As I have no Mac, I cannot test if this has any effect on the use of the Metal renderer (which has been introduced in the change where this line has been deleted).

@slouken slouken removed the bug label May 11, 2022
@slouken
Copy link
Collaborator

slouken commented Nov 5, 2023

This is fixed in the latest SDL release.

@slouken slouken closed this as completed Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants