We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4121 - Migrate the Wayland backend to xdg-shell stable
Summary: Migrate the Wayland backend to xdg-shell stable
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: video (show other bugs)
Version: HG 2.0
Hardware: x86_64 Linux
: P2 enhancement
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-01 07:49 UTC by bugs
Modified: 2018-06-25 05:52 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description bugs 2018-04-01 07:49:47 UTC 
xdg-shell has been stable since the 1.12 release of wayland-protocols in December, it is strange for SDL2 to have got support for the previous unstable version in February.

This is needed for compositors which will not implement the unstable version, note that both can be supported for the time being.

You can have a look at how I implemented it in GLFW: https://github.com/glfw/glfw/pull/1152
Comment 1 Ryan C. Gordon 2018-04-02 17:29:27 UTC 
(In reply to bugs from comment #0)
> xdg-shell has been stable since the 1.12 release of wayland-protocols in
> December, it is strange for SDL2 to have got support for the previous
> unstable version in February.

I chose that because Ubuntu 17.10 isn't shipping the stable version yet. My presumption is the "unstable" version, which is almost identical, won't be removed from Wayland systems for a long time, if ever.

(we will eventually implement the stable version in SDL, and probably also keep unstable as well for older systems.)

--ryan.
Comment 2 Ryan C. Gordon 2018-06-25 05:52:34 UTC 
(In reply to Ryan C. Gordon from comment #1)
> (we will eventually implement the stable version in SDL, and probably also
> keep unstable as well for older systems.)

And now I have, since Ubuntu 18.04 has the stable protocol:

https://hg.libsdl.org/SDL/rev/bc702c5a7c3a

--ryan.