We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4118 - SDL_windowswindow.c and SDL_mmjoystick.c are has shadowed declarison warnings
Summary: SDL_windowswindow.c and SDL_mmjoystick.c are has shadowed declarison warnings
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: video (show other bugs)
Version: HG 2.1
Hardware: All Windows (All)
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-27 08:01 UTC by Vitaly Novichkov
Modified: 2018-08-03 21:24 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vitaly Novichkov 2018-03-27 08:01:16 UTC 
Recently I have found that SDL_windowswindow.c and SDL_mmjoystick.c are got a set of "shadowed declarison" warnings:

https://ci.appveyor.com/project/Wohlstand/audiocodecs/build/job/sb7lsy2f7heuqp4k
Comment 1 Ozkan Sezer 2018-03-27 09:23:14 UTC 
Warnings are annoying yes, but those actually look harmless.
Comment 2 Vitaly Novichkov 2018-03-27 10:41:12 UTC 
It's not just a most familiar "unused" warning: Shadowed variables are jerks and may confuse you when you want to access variables with the same name in the parent scope.
Comment 3 Ryan C. Gordon 2018-08-03 21:24:11 UTC 
This is fixed in https://hg.libsdl.org/SDL/rev/0e37a23d93cb, thanks!

--ryan.