Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mouse cursor lacks transparency in High Sierra (macOS 10.13) #772

Closed
SDLBugzilla opened this issue Feb 10, 2021 · 0 comments
Closed

mouse cursor lacks transparency in High Sierra (macOS 10.13) #772

SDLBugzilla opened this issue Feb 10, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: 1.2.15
Reported for operating system, platform: macOS 10.13, x86_64

Comments on the original bug report:

On 2018-02-11 13:39:47 +0000, Mark Kim wrote:

Created attachment 3160
Example code and resulting screenshots on macOS 10.12 vs. 10.13

SDL 1.2 mouse cursors lack transparency under macOS 10.13. Pixels in the cursor icon that should be transparent are displayed as inverse-transparent pixels instead (XOR'ed with white). See the attached example code.

The issue occurs with the default cursor as well as cursors that are loaded by calling SDL_CreateCursor().

The issue was observed in macOS 10.13, built against the SDL 1.2 library (libsdl) that ships with MacPorts pkg for macOS 10.13.

The issue does not occur in macOS 10.12, built against the SDL 1.2 library (libsdl) that ships with MacPorts pkg for macOS 10.12. The issue is observable when the same binary with shared libraries are executed on macOS 10.13.

The issue has been reported to the MacPorts team who believes the issue may be in SDL (https://trac.macports.org/ticket/55804).

On 2018-02-11 13:52:37 +0000, Joshua Root wrote:

To be fair, nobody actually pointed the finger at SDL in that MacPorts ticket; in fact it seems more likely be an OS bug.

On 2018-05-17 11:57:44 +0000, kanjitalk755 wrote:

To fix this bug, please refer to the following repo.

https://github.com/kanjitalk755/SDL/tree/forHighSierra

On 2018-05-21 03:00:56 +0000, Sam Lantinga wrote:

Is this the fix?
kanjitalk755/SDL@0296d5e

On 2018-05-21 09:04:00 +0000, kanjitalk755 wrote:

Only SDL_QuartzWM.m is directly involved in fixing this bug.
SDL_QuartzVideo.h was fixed in Bug2085.
Others are fixes for building with the latest XQuartz.

On 2018-05-21 18:55:38 +0000, Mark Kim wrote:

I confirm kanjitalk755's github branch fixes the issue. Thank you!

Steps taken to confirm the fix:
0. Requirements: Tux Paint 0.9.23rc dated 2017-12-24 (the test application), MacPorts with the packages required by Tux Paint installed from source (required by Tux Paint).

  1. Download libsdl forHighSierra branch from github as a .zip file.
  2. Build the libsdl forHighSierra branch: Unzip the file, ./autogen.sh && ./configure --prefix=/opt/local && make && sudo make install. (The --prefix=/opt/local option is required by MacPorts)
  3. Build the Tux Paint application: make && make install
  4. Run TuxPaint.app

The resulting application runs as expected in all observable aspects (sound, graphics, mouse clicks, typing, etc.) The mouse cursor is displayed as expected, with no background inversion issue previously reported.

The test application was built on macOS 10.12, with its output executable tested on both macOS 10.12 and 10.13.

On 2018-05-22 05:10:11 +0000, Joshua Root wrote:

Has this been merged into the main SDL repo? Marking fixed is a bit premature if not.

On 2018-05-22 10:47:00 +0000, Ryan C. Gordon wrote:

Reopening.

On 2019-03-31 21:48:35 +0000, wrote:

Created attachment 3720
Patch extracted from https://github.com/kanjitalk755/SDL/tree/forHighSierra

Extracted from https://github.com/kanjitalk755/SDL/tree/forHighSierra, commit kanjitalk755/SDL@0296d5e mentioned here in discussion. Fixes problem for me on Mac OS 10.13 (High Sierra), not tried on other versions.

On 2019-03-31 22:05:47 +0000, wrote:

Created attachment 3721
Patch extracted from https://github.com/kanjitalk755/SDL/tree/forHighSierra - trailing newline fix

On 2019-07-30 17:49:37 +0000, Ryan C. Gordon wrote:

(Sorry if you get several emails like this, we're marking a bunch of bugs.)

We're hoping to ship SDL 2.0.11 on a much shorter timeframe than we have historically done releases, so I'm starting to tag bugs we hope to have closed in this release cycle.

Note that this tag means we just intend to scrutinize this bug for the 2.0.11 release: we may fix it, reject it, or even push it back to a later release for now, but this helps give us both a goal and a wishlist for the next release.

If this bug has been quiet for a few months and you have new information (such as, "this is definitely still broken" or "this got fixed at some point"), please feel free to retest and/or add more notes to the bug.

--ryan.

On 2019-08-03 20:35:16 +0000, Ryan C. Gordon wrote:

This patch was applied in https://hg.libsdl.org/SDL/rev/0cfa2cc751eb ... resolving this bug!

--ryan.

On 2019-09-20 20:47:38 +0000, Ryan C. Gordon wrote:

We're changing how we do SDL release versions; now releases will be even numbers (2.0.10, 2.0.12, etc), and as soon as we tag a release, we'll move the internal version number to an odd number (2.0.12 ships, we tag the latest in revision control as 2.0.13 immediately, which will become 2.0.14 on release, etc).

As such, I'm moving the bugs tagged with target-2.0.11 to target 2.0.12. Sorry if you get a lot of email from this change!

Thanks,
--ryan.

On 2019-09-20 20:48:41 +0000, Ryan C. Gordon wrote:

We're changing how we do SDL release versions; now releases will be even numbers (2.0.10, 2.0.12, etc), and as soon as we tag a release, we'll move the internal version number to an odd number (2.0.12 ships, we tag the latest in revision control as 2.0.13 immediately, which will become 2.0.14 on release, etc).

As such, I'm moving the bugs tagged with target-2.0.11 to target 2.0.12. Sorry if you get a lot of email from this change!

Thanks,
--ryan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant