We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4062 - Lot of "shadowed declaration" warnings in yuv_rgb_sse_func.h

Summary: Lot of "shadowed declaration" warnings in yuv_rgb_sse_func.h

Status:	RESOLVED FIXED

Alias:	None

Product:	SDL
Classification:	Unclassified
Component:	video (show other bugs)
Version:	HG 2.1
Hardware:	All All

Importance:	P2 normal
Assignee:	Ryan C. Gordon
QA Contact:	Sam Lantinga

URL:
Keywords:

Depends on:
Blocks:

Reported:	2018-01-22 15:10 UTC by Vitaly Novichkov
Modified:	2018-02-18 20:45 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Vitaly Novichkov 2018-01-22 15:10:09 UTC

Warnings are happen on many platforms (Linux GCC, Windows MinGW, and macOS CLang)

https://semaphoreci.com/wohlstand/sdl-mixer-x/branches/master/builds/30
https://ci.appveyor.com/project/Wohlstand/sdl-mixer-x/build/job/3jx3oj7xwk12f6q1
https://travis-ci.org/WohlSoft/SDL-Mixer-X/jobs/331386156

```
In file included from /home/runner/SDL-Mixer-X/build-debug/external/AudioCodecs/src/AudioCodecs-build/external/SDL2/src/SDL2HG/src/video/yuv2rgb/yuv_rgb.c:464:0:
/home/runner/SDL-Mixer-X/build-debug/external/AudioCodecs/src/AudioCodecs-build/external/SDL2/src/SDL2HG/src/video/yuv2rgb/yuv_rgb_sse_func.h: In function ‘yuvnv12_argb_sseu’:
/home/runner/SDL-Mixer-X/build-debug/external/AudioCodecs/src/AudioCodecs-build/external/SDL2/src/SDL2HG/src/video/yuv2rgb/yuv_rgb_sse_func.h:309:10: warning: declaration of ‘y’ shadows a previous local [-Wshadow]
  __m128i y, u, v, u_16, v_16; \
          ^
/home/runner/SDL-Mixer-X/build-debug/external/AudioCodecs/src/AudioCodecs-build/external/SDL2/src/SDL2HG/src/video/yuv2rgb/yuv_rgb_sse_func.h:432:5: note: in expansion of macro ‘YUV2RGB_32’
     YUV2RGB_32
     ^
/home/runner/SDL-Mixer-X/build-debug/external/AudioCodecs/src/AudioCodecs-build/external/SDL2/src/SDL2HG/src/video/yuv2rgb/yuv_rgb_sse_func.h:419:15: warning: shadowed declaration is here [-Wshadow]
   uint32_t x, y;
               ^
```

I'll try to fix those warnings by myself if you will don't fix that faster than me.

Comment 1 Ryan C. Gordon 2018-02-18 01:12:29 UTC

This should be fixed in https://hg.libsdl.org/SDL/rev/c3a05f3b1f8b, but let me know if I missed any.

--ryan.

Comment 2 Ryan C. Gordon 2018-02-18 01:21:22 UTC

Whoops, way too fast on the commit: https://hg.libsdl.org/SDL/rev/65634e8189f0 fixes the build.

--ryan.

Comment 3 Vitaly Novichkov 2018-02-18 20:45:25 UTC

Thanks!
Warnings now finally gone! :-D

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.