Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lot of "shadowed declaration" warnings in yuv_rgb_sse_func.h #2810

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 0 comments
Closed

Lot of "shadowed declaration" warnings in yuv_rgb_sse_func.h #2810

SDLBugzilla opened this issue Feb 11, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

SDLBugzilla commented Feb 11, 2021

This bug report was migrated from our old Bugzilla tracker.

Reported in version: HG 2.1
Reported for operating system, platform: All, All

Comments on the original bug report:

On 2018-01-22 15:10:09 +0000, Vitaly Novichkov wrote:

Warnings are happen on many platforms (Linux GCC, Windows MinGW, and macOS CLang)

https://semaphoreci.com/wohlstand/sdl-mixer-x/branches/master/builds/30
https://ci.appveyor.com/project/Wohlstand/sdl-mixer-x/build/job/3jx3oj7xwk12f6q1
https://travis-ci.org/WohlSoft/SDL-Mixer-X/jobs/331386156

In file included from /home/runner/SDL-Mixer-X/build-debug/external/AudioCodecs/src/AudioCodecs-build/external/SDL2/src/SDL2HG/src/video/yuv2rgb/yuv_rgb.c:464:0:
/home/runner/SDL-Mixer-X/build-debug/external/AudioCodecs/src/AudioCodecs-build/external/SDL2/src/SDL2HG/src/video/yuv2rgb/yuv_rgb_sse_func.h: In function ‘yuvnv12_argb_sseu’:
/home/runner/SDL-Mixer-X/build-debug/external/AudioCodecs/src/AudioCodecs-build/external/SDL2/src/SDL2HG/src/video/yuv2rgb/yuv_rgb_sse_func.h:309:10: warning: declaration of ‘y’ shadows a previous local [-Wshadow]
  __m128i y, u, v, u_16, v_16; \
          ^
/home/runner/SDL-Mixer-X/build-debug/external/AudioCodecs/src/AudioCodecs-build/external/SDL2/src/SDL2HG/src/video/yuv2rgb/yuv_rgb_sse_func.h:432:5: note: in expansion of macro ‘YUV2RGB_32’
     YUV2RGB_32
     ^
/home/runner/SDL-Mixer-X/build-debug/external/AudioCodecs/src/AudioCodecs-build/external/SDL2/src/SDL2HG/src/video/yuv2rgb/yuv_rgb_sse_func.h:419:15: warning: shadowed declaration is here [-Wshadow]
   uint32_t x, y;
               ^

I'll try to fix those warnings by myself if you will don't fix that faster than me.

On 2018-02-18 01:12:29 +0000, Ryan C. Gordon wrote:

This should be fixed in https://hg.libsdl.org/SDL/rev/c3a05f3b1f8b, but let me know if I missed any.

--ryan.

On 2018-02-18 01:21:22 +0000, Ryan C. Gordon wrote:

Whoops, way too fast on the commit: https://hg.libsdl.org/SDL/rev/65634e8189f0 fixes the build.

--ryan.

On 2018-02-18 20:45:25 +0000, Vitaly Novichkov wrote:

Thanks!
Warnings now finally gone! :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant