This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

• fix pthread return checks (pthread-error-checks.patch, text/plain, 2018-01-11 07:16:16 +0000, 2385 bytes)

Reported in version: HG 2.1
Reported for operating system, platform: Linux, All

Comments on the original bug report:

On 2018-01-11 07:16:16 +0000, Andreas Wiese wrote:

Created attachment 3131
fix pthread return checks

The pthread threading implementation does some error checks wrong. Nearly all pthread_*() functions returning int on success are defined to "return zero. Otherwise, an error number is returned to indicate the error", followed by a list of error conditions and their error values as "errno"s. This does not say anything about the sign of the error codes and indeed, most libc implementations have positive errnos. Thus correct error checking should not test for ret < 0, but for ret != 0, as otherwise the error check might be noneffective depending on used libc implementation.

On 2018-02-18 04:59:07 +0000, Ryan C. Gordon wrote:

This patch is now https://hg.libsdl.org/SDL/rev/ecddbd9fe6b5, thanks!

--ryan.