This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

• Remove references to GetVersionExA as it's deprecated in win8.x and only used to test if SDL is running on win9x (GetVersionExDeprecated.diff, text/plain, 2018-01-01 19:25:15 +0000, 978 bytes)

Reported in version: HG 2.0
Reported for operating system, platform: Windows 10, x86

Comments on the original bug report:

On 2018-01-01 19:25:15 +0000, Andrew wrote:

Created attachment 3123
Remove references to GetVersionExA as it's deprecated in win8.x and only used to test if SDL is running on win9x

GetVersionExA is deprecated in windows 8.1 and above's SDK, causing a warning when building against the win10 SDK. Attached patch cleans up the usage for a warning-free build.

GetVersionExA was being used to test to see if SDL was running on win9x or winnt. A quick chat with Ryan on twitter suggested that SDL doesn't officially support win9x anymore, so the call to this can be outright removed.

As an aside, replacing the call to GetVersionExA with VerifyVersionInfoA (the recommended path) would have been pointless, as VerifyVersionInfoA only supports VER_PLATFORM_WIN32_NT and doesn't officially support any other value for dwPlatformId currently. (And it's probable that win9x SDKs didn't have VerifyVersionInfo* in them anyway.)

Patch attached with the quick cleanup.

On 2018-01-03 18:04:05 +0000, Sam Lantinga wrote:

Fixed, thanks!
https://hg.libsdl.org/SDL/rev/454f6dc9cb85

On 2018-01-08 05:41:33 +0000, Ryan C. Gordon wrote:

*** Bug 4031 has been marked as a duplicate of this bug. ***