Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS: don't hide keyboard on RETURN (patch included) #2757

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 0 comments
Closed

iOS: don't hide keyboard on RETURN (patch included) #2757

SDLBugzilla opened this issue Feb 11, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: 2.0.7
Reported for operating system, platform: iOS (All), iPhone/iPod touch

Comments on the original bug report:

On 2017-12-17 11:56:11 +0000, Dominik Reichardt wrote:

Created attachment 3115
patch

As discussed in 2012 the iOS onscreen keyboard hides when you hit RETURN (see https://discourse.libsdl.org/t/on-screen-keyboard-change/19216).
IMO this is a bad idea to not be able to influence this behavior and just recently this was fixed for Android by adding the hint SDL_HINT_ANDROID_RETURN_HIDES_IME in changeset 11768 0f2fb9ec6ad6.

I've included a little patch for this but you probably want to change the HINT name.

Perhaps it might be good to make this a shared hint for both Android and iOS but that would mean thinking about the correct default behavior.

On 2017-12-17 13:15:57 +0000, Dominik Reichardt wrote:

Created attachment 3116
Patch to unify Android and iOS hint

Added a patch to make this one hint for both Android and SDL "SDL_HINT_MOBILE_RETURN_HIDES_IME"

On 2017-12-19 18:57:53 +0000, Sam Lantinga wrote:

I renamed the hint so this can apply on other platforms as well.
https://hg.libsdl.org/SDL/rev/98ea6e4c0d68

Thanks!

@SDLBugzilla SDLBugzilla added the enhancement New feature or request label Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant