We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3995 - SDL failed to upgrade the solution files
Summary: SDL failed to upgrade the solution files
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: file (show other bugs)
Version: HG 2.1
Hardware: x86 Windows 10
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-07 08:33 UTC by shanshan
Modified: 2017-12-11 05:25 UTC (History)
0 users

See Also:

Attachments
Upgrade log file (63.17 KB, text/html)
2017-12-08 05:51 UTC, shanshan 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description shanshan 2017-12-07 08:33:50 UTC 
SDL failed to upgrade the solution files. This issue can be reproduced from default revision 27d08f1aab80. Could you please help have a look about this issue? Thanks in advance!


Environment:Windows Server 2016 + VS2015 Update 3 + SDL default branch latest source

Steps to Reproduce:
1.hg clone https://hg.libsdl.org/SDL D:\SDL\src
2.Open a VS 2017 x86 command prompt as admin and browse to D:\SDL\src
3.devenv /upgrade VisualC\SDL.sln

Actual result:
Upgrade the solution files fails.
Comment 1 Sam Lantinga 2017-12-07 16:26:07 UTC 
I'm not able to reproduce that here. What is the output in the upgrade log?
Comment 2 shanshan 2017-12-08 05:51:04 UTC 
Created attachment 3111 [details]
Upgrade log file
Comment 3 shanshan 2017-12-08 06:04:17 UTC 
Hi @Sam Lantinga, thanks for looking into this. I've attached the output in the upgrade log. BTW, the reason for this issue appears to be that there are two same "<ClInclude Include="..\..\src\audio\wasapi\SDL_wasapi.h" />" in the /VisualC/SDL/SDL.vcxproj.
Comment 4 Sam Lantinga 2017-12-09 00:13:25 UTC 
Thanks! This should fix it:
https://hg.libsdl.org/SDL/rev/0e15bc808bc1
Comment 5 shanshan 2017-12-11 04:44:30 UTC 
@Sam Lantinga, thank you so much for fixing this issue. I've verified your fix works well.
Comment 6 Sam Lantinga 2017-12-11 05:25:12 UTC 
Thanks!