This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

• Patch to fix Win10 XInput binding (file_3960.txt, text/plain, 2018-02-21 17:44:19 +0000, 909 bytes)

Reported in version: HG 2.1
Reported for operating system, platform: Windows 10, All

Comments on the original bug report:

On 2017-11-14 18:34:12 +0000, Ethan Lee wrote:

For WinRT, XInput always forces the old code path for all versions:

https://hg.libsdl.org/SDL/file/cf166abbde4a/src/joystick/windows/SDL_xinputjoystick.c#l39

Looking around briefly it seems this might have been required for Windows 8 (?), but I think for Windows 10 the new path is required. In its current form, ABXY is unintentionally mapped to the physical d-pad due to this array:

https://hg.libsdl.org/SDL/file/cf166abbde4a/src/joystick/windows/SDL_xinputjoystick.c#l349

By changing the hardcoded return value to SDL_FALSE, we use the new path where the array properly lines up...

https://hg.libsdl.org/SDL/file/cf166abbde4a/src/joystick/windows/SDL_xinputjoystick.c#l375

... and the issue is resolved for me.

On 2018-02-21 17:44:19 +0000, Ethan Lee wrote:

Created attachment 3177
Patch to fix Win10 XInput binding

Attached is a patch to fix this issue without changing the behavior on Windows 8, which presumably needed the old path to begin with.

On 2018-02-21 18:16:49 +0000, Ryan C. Gordon wrote:

This patch is now https://hg.libsdl.org/SDL/rev/1a033404c88b, thanks!

(note the commit hash changed because of Windows newlines, so be careful when updating your local copy.)

--ryan.