We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3957 - build failures introduced by recent commits
Summary: build failures introduced by recent commits
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: *don't know* (show other bugs)
Version: HG 2.0
Hardware: All All
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
: 3961 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-11-13 12:18 UTC by Ozkan Sezer
Modified: 2017-11-17 19:41 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ozkan Sezer 2017-11-13 12:18:47 UTC
build failures (and warnings) introduced by recent commits:


1.  changeset 11702: cf166abbde4a
testoverlay2.c and testyuv.c depend on testyuv_cvt.c, patch below:

diff --git a/VisualC/tests/testoverlay2/testoverlay2.vcxproj b/VisualC/tests/testoverlay2/testoverlay2.vcxproj
--- a/VisualC/tests/testoverlay2/testoverlay2.vcxproj
+++ b/VisualC/tests/testoverlay2/testoverlay2.vcxproj
@@ -212,6 +212,7 @@
   </ItemGroup>
   <ItemGroup>
     <ClCompile Include="..\..\..\test\testoverlay2.c" />
+    <ClCompile Include="..\..\..\test\testyuv_cvt.c" />
   </ItemGroup>
   <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
   <ImportGroup Label="ExtensionTargets">
diff --git a/test/Makefile.in b/test/Makefile.in
--- a/test/Makefile.in
+++ b/test/Makefile.in
@@ -219,7 +219,7 @@
 endif
 endif
 
-testoverlay2$(EXE): $(srcdir)/testoverlay2.c
+testoverlay2$(EXE): $(srcdir)/testoverlay2.c $(srcdir)/testyuv_cvt.c
 	$(CC) -o $@ $^ $(CFLAGS) $(LIBS)
 
 testplatform$(EXE): $(srcdir)/testplatform.c
@@ -267,7 +267,7 @@
 testwm2$(EXE): $(srcdir)/testwm2.c
 	$(CC) -o $@ $^ $(CFLAGS) $(LIBS)
 
-testyuv$(EXE): $(srcdir)/testyuv.c
+testyuv$(EXE): $(srcdir)/testyuv.c $(srcdir)/testyuv_cvt.c
 	$(CC) -o $@ $^ $(CFLAGS) $(LIBS)
 
 torturethread$(EXE): $(srcdir)/torturethread.c



2.  changeset 11702: cf166abbde4a
yuv_rgb.h includes stdint.h, which is not present in MSVC < 2013.
stdint.h need is already handled by sources that include yuv_rg.h,
so comment it out:

diff --git a/src/video/yuv2rgb/yuv_rgb.h b/src/video/yuv2rgb/yuv_rgb.h
--- a/src/video/yuv2rgb/yuv_rgb.h
+++ b/src/video/yuv2rgb/yuv_rgb.h
@@ -16,7 +16,7 @@
 // For all methods, width and height should be even, if not, the last row/column of the result image won't be affected.
 // For sse methods, if the width if not divisable by 32, the last (width%32) pixels of each line won't be affected.
 
-#include <stdint.h>
+//#include <stdint.h> /* handled by sources including this header */
 
 typedef enum
 {



3.  changeset 11698: c5ae532b96d0 (along with 11699: afe271f50c70)
immintrin.h is provided by newer gcc:  this commit not only breaks
building SDL2 with old gcc, but it also breaks building stuff against
SDL2 headers using old gcc.  I have no patch for this.



4.  changeset 11683: 48bcba563d9c
My VS2005 emits the following warnings with the updated libm sources:

1>c:\sdl2\src\libm\e_log.c(91) : warning C4723: potential divide by 0
1>c:\sdl2\src\libm\e_log.c(92) : warning C4723: potential divide by 0
1>c:\sdl2\src\libm\e_pow.c(182) : warning C4756: overflow in constant arithmetic
1>c:\sdl2\src\libm\e_pow.c(183) : warning C4756: overflow in constant arithmetic
1>c:\sdl2\src\libm\e_pow.c(186) : warning C4756: overflow in constant arithmetic
1>c:\sdl2\src\libm\e_pow.c(187) : warning C4756: overflow in constant arithmetic

I have no patch for these.
Comment 1 Sam Lantinga 2017-11-17 18:56:02 UTC
Patches 1 and 2 are in:
https://hg.libsdl.org/SDL/rev/e8cd7b48dc0a
https://hg.libsdl.org/SDL/rev/ddc0bae7ca1a

Can you open separate bugs for the other two issues?

Thanks!
Comment 2 Sam Lantinga 2017-11-17 18:56:45 UTC
*** Bug 3961 has been marked as a duplicate of this bug. ***