We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3932 - Android, GetDisplayDPI release local reference
Summary: Android, GetDisplayDPI release local reference
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: *don't know* (show other bugs)
Version: don't know
Hardware: All Android (All)
: P2 major
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-01 08:11 UTC by Sylvain
Modified: 2017-11-02 00:30 UTC (History)
0 users

See Also:

Attachments
patch (539 bytes, patch)
2017-11-01 08:11 UTC, Sylvain 		Details | Diff
patch (725 bytes, patch)
2017-11-01 08:39 UTC, Sylvain 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sylvain 2017-11-01 08:11:40 UTC 
Created attachment 3052 [details]
patch

Same kind of fixed like in bug 3917

When writing JNI code, one has to make sure all local references are released otherwise the app end up crashing.
Comment 1 Sylvain 2017-11-01 08:39:41 UTC 
Created attachment 3053 [details]
patch

Small modification so that "Diagonal, horizontal and vertical DPI can all be optionally returned if the parameter is non-NULL."
Comment 2 Sam Lantinga 2017-11-02 00:30:25 UTC 
Fixed, thanks!
https://hg.libsdl.org/SDL/rev/861f42ecf09a