We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3914 - [PATCH] Add a specific Raspberry Pi hint for low latency video
Summary: [PATCH] Add a specific Raspberry Pi hint for low latency video
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: video (show other bugs)
Version: 2.0.6
Hardware: ARM Linux
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-23 15:15 UTC by Manuel Alfayate Corchete
Modified: 2017-11-07 17:13 UTC (History)
2 users (show)

See Also:

Attachments
Small patch for low latency mode hint on the Raspberry Pi video driver (5.14 KB, patch)
2017-10-23 15:15 UTC, Manuel Alfayate Corchete 		Details | Diff
Updated (hopefully final) patch for the Raspberry Pi low-latency hint (5.23 KB, patch)
2017-10-24 00:34 UTC, Manuel Alfayate Corchete 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Alfayate Corchete 2017-10-23 15:15:42 UTC 
Created attachment 3034 [details]
Small patch for low latency mode hint on the Raspberry Pi video driver

Adds optional double-buffering (instead of default triple-buffering) hint for the Raspberry Pi driver, for low-latency scenarios.
Similar to patch https://bugzilla.libsdl.org/show_bug.cgi?id=3902
but specific for the Raspberry Pi driver.

Thanks


Manuel Alfayate
Comment 1 Manuel Alfayate Corchete 2017-10-24 00:34:49 UTC 
Created attachment 3036 [details]
Updated (hopefully final) patch for the Raspberry Pi low-latency hint
Comment 2 Alex Szpakowski 2017-10-24 17:57:02 UTC 
Does it make sense to combine the two hints (and list which platforms they apply to in the hint comment), so people can just set one hint if they want the functionality, even if it's used in more backends later down the line?
Comment 3 Manuel Alfayate Corchete 2017-10-29 10:26:41 UTC 
(In reply to Alex Szpakowski from comment #2)
> Does it make sense to combine the two hints (and list which platforms they
> apply to in the hint comment), so people can just set one hint if they want
> the functionality, even if it's used in more backends later down the line?

Do you mean a general SDL_HINT_DOUBLE_BUFFER hint? Well, maybe later when more/if more backends implement this, it could be interesting. But for now, I think it's enough as it is, since these are pretty specific.
Comment 4 Manuel Alfayate Corchete 2017-10-31 10:48:40 UTC 
Is there a problem with this patch beyond that suggestion? If it's a must, I can make it a general SDL_HINT_DOUBLE_BUFFER thing that some drivers support and others not, but I'd like to see it merged as I need to consider it "done".
Comment 5 Manuel Alfayate Corchete 2017-11-06 00:37:58 UTC 
This patch is now OBSOLETED in favor of https://bugzilla.libsdl.org/show_bug.cgi?id=3943

PLEASE DON'T MERGE. Merge https://bugzilla.libsdl.org/show_bug.cgi?id=3943 instead.
Comment 6 Brandon Schaefer 2017-11-07 17:13:17 UTC 
The patch that spawned from this bug has been merged:
https://hg.libsdl.org/SDL/rev/2ce56475ad57