We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3913 - SDL_net build fixes for OS/2
Summary: SDL_net build fixes for OS/2
Status: RESOLVED FIXED
Alias: None
Product: SDL_net
Classification: Unclassified
Component: misc (show other bugs)
Version: unspecified
Hardware: x86 OS/2
: P2 normal
Assignee: Sam Lantinga
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-23 11:42 UTC by Ozkan Sezer
Modified: 2017-10-23 18:54 UTC (History)
0 users

See Also:

Attachments
sdlnet_os2.patch (1.87 KB, patch)
2017-10-23 11:42 UTC, Ozkan Sezer 		Details | Diff
sdlnet_os2_2.patch (404 bytes, patch)
2017-10-23 15:34 UTC, Ozkan Sezer 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ozkan Sezer 2017-10-23 11:42:51 UTC 
Created attachment 3032 [details]
sdlnet_os2.patch

The attached patch applies some OS/2 build fixes to SDL_net
when using Open Watcom.

Regards.
Comment 1 Sam Lantinga 2017-10-23 15:27:07 UTC 
Fixed, thanks!
https://hg.libsdl.org/SDL_net/rev/08b8e85c1911
Comment 2 Ozkan Sezer 2017-10-23 15:34:11 UTC 
Created attachment 3035 [details]
sdlnet_os2_2.patch

Attached a correction patch to the FIXME I added:

IBM OS/2 socket implementation doesn't provide a function to reset
socket errno: therefore, do not set errno in SDLNet_SetLastError().
Comment 3 Ozkan Sezer 2017-10-23 16:34:28 UTC 
(forgot reopening after attaching the 2nd patch)
Comment 4 Sam Lantinga 2017-10-23 18:54:38 UTC 
This is in!
https://hg.libsdl.org/SDL_net/rev/936c77fee373