We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3885 - smpeg2 fails build if USE_SYSTEM_THREAD is defined
Summary: smpeg2 fails build if USE_SYSTEM_THREAD is defined
Status: RESOLVED FIXED
Alias: None
Product: SDL_mixer
Classification: Unclassified
Component: misc (show other bugs)
Version: unspecified
Hardware: All All
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-15 21:17 UTC by Ozkan Sezer
Modified: 2017-10-18 05:11 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ozkan Sezer 2017-10-15 21:17:08 UTC 
smpeg2 in SDL_mixer fails build if USE_SYSTEM_THREAD is defined:

MPEGsystem.cpp: In constructor ‘MPEGsystem::MPEGsystem(SDL_RWops*)’:
MPEGsystem.cpp:443: error: cannot convert ‘MPEGsystem* const’ to ‘const char*’ for argument ‘2’ to ‘SDL_Thread* SDL_CreateThread(int (*)(void*), const char*, void*)’
MPEGsystem.cpp: In member function ‘virtual void MPEGsystem::Start()’:
MPEGsystem.cpp:1251: error: cannot convert ‘MPEGsystem* const’ to ‘const char*’ for argument ‘2’ to ‘SDL_Thread* SDL_CreateThread(int (*)(void*), const char*, void*)’

The thread name parameter to SDL_CreateThread() is missing in the
two calls.
Comment 1 Sam Lantinga 2017-10-18 05:11:05 UTC 
Fixed, thanks!
https://hg.libsdl.org/SDL_mixer/rev/2b559c85819d