Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL_FreeSurface deallocates surface->map even if the surface is not yet freed #2638

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

Reported in version: HG 2.1
Reported for operating system, platform: All, All

Comments on the original bug report:

On 2017-09-28 14:26:25 +0000, Evgeny Kapun wrote:

Commit 52dcef74bdc5 [1], which was a fix for bug # 3790, introduced a new bug: now, calling SDL_FreeSurface(surface) deallocates surface->map even if there are other references to the surface. This is bad, because some functions (such as SDL_ConvertSurface) assume that surface->map is not NULL.

[1] https://hg.libsdl.org/SDL/rev/52dcef74bdc5

On 2017-09-29 14:44:52 +0000, Sam Lantinga wrote:

Argh, thank you. This is fixed:
https://hg.libsdl.org/SDL/rev/a09c3f87a12f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant