This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

• Testcase (sdl2_resample_popping.zip, application/zip, 2017-09-24 19:36:21 +0000, 7227 bytes)
• Recording of the testcase with bug (recording.wav, audio/x-wav, 2017-10-14 08:35:07 +0000, 60838 bytes)

Reported in version: HG 2.1
Reported for operating system, platform: Linux, x86

Comments on the original bug report:

On 2017-09-24 19:36:21 +0000, Dávid Nagy wrote:

Created attachment 2960
Testcase

When playing the attached WAV file using the attached program, the sound is played back with some popping noises.

SDL 2.0.5 and the pre-release of SDL 2.0.6 did not have the bug, but the final SDL 2.0.6 has the bug.
(I'm referring to this pre-release: https://discourse.libsdl.org/t/sdl-2-0-6-prerelease/23024)

The bug exists since this revision: https://hg.libsdl.org/SDL/rev/a8382e3d0b54

A very similar popping noise was fixed by this revision: https://hg.libsdl.org/SDL/rev/4cdc242e4102

On 2017-10-08 18:17:39 +0000, Ozkan Sezer wrote:

Does the patch in bug # 3851 fix this?

On 2017-10-11 06:40:08 +0000, Ryan C. Gordon wrote:

(In reply to Ozkan Sezer from comment # 1)

Does the patch in bug # 3851 fix this?

I assume this is a duplicate of Bug # 3851, which should now be fixed.

--ryan.

*** This bug has been marked as a duplicate of bug 3851 ***

On 2017-10-14 08:35:07 +0000, Dávid Nagy wrote:

Created attachment 2983
Recording of the testcase with bug

I tried revision c48ab2c208a2, but my problem is still present.

I attached a recording of what my testcase sounds like with the bug.

When I examined the recording with Audacity, I noticed that when the waveform reaches -1.0, it repeatedly jumps to +1.0 and back, and this causes the popping.

This looks like an overflow.

On 2017-10-14 08:37:43 +0000, Dávid Nagy wrote:

Reopening bug.

On 2017-10-21 14:35:20 +0000, Dávid Nagy wrote:

The fix for bug # 3876 fixed this bug as well: https://hg.libsdl.org/SDL/rev/37aca00967db

Closing bug.

On 2017-10-21 17:14:02 +0000, Sam Lantinga wrote:

Thanks!