We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3829 - duplicated game controller entry added in commit 11499:405cbb1039b1?
Summary: duplicated game controller entry added in commit 11499:405cbb1039b1?
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: joystick (show other bugs)
Version: HG 2.0
Hardware: All All
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-14 18:55 UTC by Ozkan Sezer
Modified: 2017-09-14 19:46 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ozkan Sezer 2017-09-14 18:55:55 UTC 
Commit https://hg.libsdl.org/SDL/rev/405cbb1039b1 adds mapping
for the GUID 030000004c0500006802000000000000 as "GameSir G4s"
under dinput section (line 46 in SDL_gamecontrollerdb.h),  but
that seems like a duplicate of "PS3 Controller" with same GUID
at line 63 still in the dinput section with the same mappings.
Comment 1 Patrice Mandin 2017-09-14 19:41:51 UTC 
Ah you are right, I cared about having names sorted, but did not notice this controller was using exactly the same GUID. I remove it then.
Comment 2 Patrice Mandin 2017-09-14 19:46:12 UTC 
Commit reverted.