We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3824 - IMG_WIC.c compile error
Summary: IMG_WIC.c compile error
Status: RESOLVED FIXED
Alias: None
Product: SDL_image
Classification: Unclassified
Component: misc (show other bugs)
Version: unspecified
Hardware: All All
: P2 critical
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-13 15:28 UTC by Olli Kallioinen
Modified: 2017-09-13 17:06 UTC (History)
0 users

See Also:


Attachments
Patch: missing #endif added (486 bytes, patch)
2017-09-13 15:28 UTC, Olli Kallioinen
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olli Kallioinen 2017-09-13 15:28:02 UTC
Getting error:

    [armeabi-v7a] Compile thumb  : SDL2_image <= IMG_WIC.c
    :22:2: error: unterminated conditional directive
    #if defined(SDL_IMAGE_USE_WIC_BACKEND)

Seems that the #endif is missing. I assume the whole file should be enclosed

Note: I was compiling for android using clang. Maybe GCC let's it compile. I don't know how else this would go unnoticed.
Comment 1 Olli Kallioinen 2017-09-13 15:28:56 UTC
Created attachment 2931 [details]
Patch: missing #endif added
Comment 2 Sam Lantinga 2017-09-13 17:06:17 UTC
Fixed, thanks!
https://hg.libsdl.org/SDL_image/rev/e499c5ed8efc