We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3807 - Remove restriction from DECLSPEC macro for OS/2
Summary: Remove restriction from DECLSPEC macro for OS/2
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: build (show other bugs)
Version: HG 2.0
Hardware: x86 OS/2
: P2 trivial
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-09 14:40 UTC by Ozkan Sezer
Modified: 2017-09-09 14:42 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ozkan Sezer 2017-09-09 14:40:31 UTC 
The following patch removes the unnecessary / wrong
Watcom restriction from the DECLSPEC macro for OS/2.

diff --git a/include/begin_code.h b/include/begin_code.h
--- a/include/begin_code.h
+++ b/include/begin_code.h
@@ -61,7 +61,7 @@
 #  else
 #   define DECLSPEC __declspec(dllexport)
 #  endif
-# elif defined(__OS2__) && defined(__WATCOMC__)
+# elif defined(__OS2__)
 #   ifdef BUILD_SDL
 #    define DECLSPEC    __declspec(dllexport)
 #   else
Comment 1 Sam Lantinga 2017-09-09 14:42:49 UTC 
Fixed!
https://hg.libsdl.org/SDL/rev/27a1926addec