We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3806 - Fixes for MSVC compiler warnings for b3bb3855bc41
Summary: Fixes for MSVC compiler warnings for b3bb3855bc41
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: *don't know* (show other bugs)
Version: HG 2.0
Hardware: All Windows (All)
: P2 trivial
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-09 01:13 UTC by Simon Hug
Modified: 2017-09-09 01:26 UTC (History)
0 users

See Also:

Attachments
Fixes some compiler warnings. (1.78 KB, patch)
2017-09-09 01:13 UTC, Simon Hug 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Hug 2017-09-09 01:13:31 UTC 
Created attachment 2917 [details]
Fixes some compiler warnings.

These are the remaining compiler warnings I see in the current tip b3bb3855bc41.

- SDL_test_log.c defines _CRT_SECURE_NO_WARNINGS without checking if it was already set.

- SDL_windowskeyboard.c converts integers to pointers without going over the (U)INT_PTR types. That bothers MSVC.
Comment 1 Sam Lantinga 2017-09-09 01:26:50 UTC 
Fixed, thanks!
https://hg.libsdl.org/SDL/rev/510e461e584a