We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3773 - Cannot build with libmad support
Summary: Cannot build with libmad support
Status: RESOLVED FIXED
Alias: None
Product: SDL_mixer
Classification: Unclassified
Component: misc (show other bugs)
Version: unspecified
Hardware: x86_64 Linux
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-24 14:36 UTC by sfalexrog
Modified: 2017-08-26 04:28 UTC (History)
0 users

See Also:

Attachments
Proposed fix (545 bytes, patch)
2017-08-24 14:36 UTC, sfalexrog 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description sfalexrog 2017-08-24 14:36:54 UTC 
Created attachment 2885 [details]
Proposed fix

As of hg d10f63427a5f, SDL_mixer fails to build with libmad support, complaining about unknown "mixer" variable in a call to SDL_MixAudioFormat (lines 267-268). This was introduced in hg 298d69a81cc9.

In music_mad.c, mixer is not defined as a global variable, but is stored in the mad_data structure. A possible fix would be to access the mixer stored in mad_data.
Comment 1 Sam Lantinga 2017-08-26 04:28:17 UTC 
Fixed, thanks!
https://hg.libsdl.org/SDL_mixer/rev/0a88173a913a