We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3742 - minor warning fixes
Summary: minor warning fixes
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: video (show other bugs)
Version: HG 2.0
Hardware: All All
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-13 11:18 UTC by Ozkan Sezer
Modified: 2017-08-14 04:17 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ozkan Sezer 2017-08-13 11:18:46 UTC
src/video/x11/SDL_x11video.c:198: warning: implicit declaration of function 'SDL_Delay_REAL'
Warning came with rev.11252

src/video/windows/SDL_windowsmodes.c:39:20: warning: unused variable 'vid_data'
Warning came with rev.11218

Patch below.

diff -r f7abcb63e51e src/video/windows/SDL_windowsmodes.c
--- a/src/video/windows/SDL_windowsmodes.c	Sun Aug 13 01:00:01 2017 -0400
+++ b/src/video/windows/SDL_windowsmodes.c	Sun Aug 13 14:11:05 2017 +0300
@@ -36,7 +36,6 @@
 static void
 WIN_UpdateDisplayMode(_THIS, LPCTSTR deviceName, DWORD index, SDL_DisplayMode * mode)
 {
-    SDL_VideoData *vid_data = (SDL_VideoData *) _this->driverdata;
     SDL_DisplayModeData *data = (SDL_DisplayModeData *) mode->driverdata;
     HDC hdc;
 
@@ -54,7 +53,7 @@
 
         mode->w = logical_width;
         mode->h = logical_height;
-        
+
         SDL_zero(bmi_data);
         bmi = (LPBITMAPINFO) bmi_data;
         bmi->bmiHeader.biSize = sizeof(BITMAPINFOHEADER);
diff -r f7abcb63e51e src/video/x11/SDL_x11video.c
--- a/src/video/x11/SDL_x11video.c	Sun Aug 13 01:00:01 2017 -0400
+++ b/src/video/x11/SDL_x11video.c	Sun Aug 13 14:11:05 2017 +0300
@@ -26,6 +26,7 @@
 
 #include "SDL_video.h"
 #include "SDL_mouse.h"
+#include "SDL_timer.h"
 #include "../SDL_sysvideo.h"
 #include "../SDL_pixels_c.h"
Comment 1 Sam Lantinga 2017-08-14 04:17:16 UTC
Fixed, thanks!
https://hg.libsdl.org/SDL/rev/ebbad52788e1