We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3735 - [patch] Add support for [GLX/WGL]_ARB_create_context_robustness
Summary: [patch] Add support for [GLX/WGL]_ARB_create_context_robustness
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: video (show other bugs)
Version: HG 2.1
Hardware: All All
: P2 enhancement
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords: target-2.0.6
: 3643 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-08-10 13:30 UTC by Maximilian Malek
Modified: 2017-08-19 19:04 UTC (History)
1 user (show)

See Also:

Attachments
patch file (6.93 KB, patch)
2017-08-10 13:30 UTC, Maximilian Malek 		Details | Diff
Test program (2.07 KB, text/plain)
2017-08-10 13:33 UTC, Maximilian Malek 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maximilian Malek 2017-08-10 13:30:26 UTC 
Created attachment 2824 [details]
patch file

The attached patch adds some missing bits for full ARB_robustness compatibility,
specifically support for glGetGraphicsResetStatus() via WGL_ARB_create_context_robustness and GLX_ARB_create_context_robustness.

This builds upon patch [https://bugzilla.libsdl.org/show_bug.cgi?id=3643] and adds the WGL version.
I have removed support for NV_robustness_video_memory_purge from that patch because the extension states "This extension will have a limited lifespan" and I figured that adding an SDL API for a temporary NV-only extension isn't worth it.
I've also renamed the new enum values a bit to be more consistent.
Comment 1 Maximilian Malek 2017-08-10 13:33:24 UTC 
Created attachment 2825 [details]
Test program

A test program for the patch. On a recent GL 4.5 compatible setup + patched SDL it should print "GL context is fully robust".
Comment 2 Ryan C. Gordon 2017-08-10 16:09:47 UTC 
*** Bug 3643 has been marked as a duplicate of this bug. ***
Comment 3 Ryan C. Gordon 2017-08-19 19:04:14 UTC 
This patch is now https://hg.libsdl.org/SDL/rev/e3797888c6f1, thanks!

--ryan.