We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Created attachment 2805 [details]
mpg123 support patch

hello, I was playing with SDL2_mixer and I've noticed that smpeg2 has major issues loading specific malformed/exotic mp3 files such as mp3 files with japanese metadata, which made it hang upon loading the file.

after googling around, I found a github issue about SDL_mixer's mp3 support and they ended up plugging libmpg123 using the music player hook.

libmad seems to do okay for me, but the aforementioned issue reports "noises or crashes due to buffer issues" and both libmad and smpeg2 appear to be unmaintained for many years, so I thought I'd add a libmpg123 mp3 module.

thanks to mpg123's flexible interface I was able to achieve this quickly and with little code, and it even supports seeking. this is a lot cleaner than using the MusicPlayer hook and more flexible.

you can find some advantages of mpg123 on the aforementioned github issue (https://github.com/EasyRPG/Player/issues/818), but basically it handles broken or exotic files much better than mad and smpeg (especially smpeg), and it's a bit more maintained from what I can see.

I have attached the patch, first time working with mercurial and sending patches through mail so there might be mistakes.