We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3701 - WM_TOUCH message may cause calls to null if touch functions are not properly loaded
Summary: WM_TOUCH message may cause calls to null if touch functions are not properly ...
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: events (show other bugs)
Version: HG 2.0
Hardware: All Windows (XP)
: P2 minor
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords: target-2.0.6
Depends on:
Blocks:
 
Reported: 2017-07-14 00:27 UTC by Simon Hug
Modified: 2017-08-10 03:26 UTC (History)
0 users

See Also:

Attachments
Patch that adds NULL-pointer checks to WM_TOUCH handling. (612 bytes, patch)
2017-07-14 00:27 UTC, Simon Hug 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Hug 2017-07-14 00:27:40 UTC 
Created attachment 2797 [details]
Patch that adds NULL-pointer checks to WM_TOUCH handling.

When WIN_WindowProc processes the WM_TOUCH message [1], it doesn't check if the touch functions have been properly loaded and may call a NULL pointer. It's probably an extremely rare case, but here's a patch that adds some checks anyway.

[1] https://hg.libsdl.org/SDL/file/424607440631/src/video/windows/SDL_windowsevents.c#l890
Comment 1 Ryan C. Gordon 2017-08-09 05:25:35 UTC 
(Sorry if you get a lot of copies of this email, we're touching dozens of bug reports right now.)

Tagging a bunch of bugs as target-2.0.6.

This means we're in the final stretch for an official SDL 2.0.6 release! These are the bugs we really want to fix before shipping if humanly possible.

That being said, we don't promise to fix them because of this tag, we just want to make sure we don't forget to deal with them before we bless a final 2.0.6 release, and generally be organized about what we're aiming to ship. After some debate, we might just remove this tag again and deal with it for a later release.

Hopefully you'll hear more about this bug soon. If you have more information (including "this got fixed at some point, nevermind"), we would love to have you come add more information to the bug report when you have a moment.

Thanks!
--ryan.
Comment 2 Sam Lantinga 2017-08-10 03:26:30 UTC 
Fixed, thanks!
https://hg.libsdl.org/SDL/rev/51aeabb61b2e