We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3688 - cmake / pthread check related patch proposal
Summary: cmake / pthread check related patch proposal
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: build (show other bugs)
Version: HG 2.1
Hardware: All All
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-30 11:56 UTC by Juha Niemimäki
Modified: 2017-07-11 01:40 UTC (History)
0 users

See Also:

Attachments
Fix for PTHREAD_MUTEX_RECURSIVE_NP check and restoring the original flags (1.12 KB, patch)
2017-06-30 11:56 UTC, Juha Niemimäki 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Juha Niemimäki 2017-06-30 11:56:12 UTC 
Created attachment 2784 [details]
Fix for PTHREAD_MUTEX_RECURSIVE_NP check and restoring the original flags

Two fixes proposed:

1) Looks like there is a copy-paste issue regarding PTHREAD_MUTEX_RECURSIVE_NP check.

2) Compiler flag restoration doesn't look symmetrical regarding if/endif blocks. Moved to an outer block (if PTHREADS).
Comment 1 Sam Lantinga 2017-07-11 01:40:55 UTC 
Fixed, thanks!
https://hg.libsdl.org/SDL/rev/4c165b1a0596