We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3682 - [patch] Toggle text input in checkkeys when the mouse is clicked
Summary: [patch] Toggle text input in checkkeys when the mouse is clicked
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: *don't know* (show other bugs)
Version: HG 2.1
Hardware: x86 Other
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords: target-2.0.6
Depends on:
Blocks:
 
Reported: 2017-06-25 21:09 UTC by Eric Wasylishen
Modified: 2017-08-11 17:33 UTC (History)
1 user (show)

See Also:

Attachments
Patch for toggling text input in checkkeys sample (713 bytes, patch)
2017-06-25 21:09 UTC, Eric Wasylishen 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Wasylishen 2017-06-25 21:09:11 UTC 
Created attachment 2775 [details]
Patch for toggling text input in checkkeys sample

Small change to checkkeys so you can toggle text input mode with a mouse click.
This is needed for testing how dead keys react to toggling mouse input, i.e. these bugs:

https://bugzilla.libsdl.org/show_bug.cgi?id=3458
https://bugzilla.libsdl.org/show_bug.cgi?id=3332
Comment 1 Eric Wasylishen 2017-06-26 20:44:13 UTC 
oops, last comment should read "how dead keys react to toggling TEXT input" not "mouse input".
Comment 2 Ryan C. Gordon 2017-08-09 05:25:35 UTC 
(Sorry if you get a lot of copies of this email, we're touching dozens of bug reports right now.)

Tagging a bunch of bugs as target-2.0.6.

This means we're in the final stretch for an official SDL 2.0.6 release! These are the bugs we really want to fix before shipping if humanly possible.

That being said, we don't promise to fix them because of this tag, we just want to make sure we don't forget to deal with them before we bless a final 2.0.6 release, and generally be organized about what we're aiming to ship. After some debate, we might just remove this tag again and deal with it for a later release.

Hopefully you'll hear more about this bug soon. If you have more information (including "this got fixed at some point, nevermind"), we would love to have you come add more information to the bug report when you have a moment.

Thanks!
--ryan.
Comment 3 Sam Lantinga 2017-08-11 17:33:19 UTC 
I changed it to toggle text input on right click, but otherwise this looks good:
https://hg.libsdl.org/SDL/rev/54ea94875b88

Thanks!