Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake IOS haptic error #2472

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 0 comments
Closed

CMake IOS haptic error #2472

SDLBugzilla opened this issue Feb 11, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

Reported in version: HG 2.1
Reported for operating system, platform: iOS (All), All

Comments on the original bug report:

On 2017-06-11 17:46:53 +0000, Martin Gerhardy wrote:

endif()

if(SDL_HAPTIC)
set(SDL_HAPTIC_IOKIT 1)
if (IOS)

  •  file(GLOB HAPTIC_SOURCES ${SDL2_SOURCE_DIR}/src/haptic/dummy/*.c)
    
  •  file(GLOB POWER_SOURCES ${SDL2_SOURCE_DIR}/src/power/dummy/*.c)
     set(SDL_HAPTIC_DUMMY 1)
    
    else()
    file(GLOB HAPTIC_SOURCES ${SDL2_SOURCE_DIR}/src/haptic/darwin/*.c)

Somehow the power sources slipped into the ios cmake section for the haptic dummy driver

On 2017-06-11 20:01:18 +0000, Ryan C. Gordon wrote:

This patch is now https://hg.libsdl.org/SDL/rev/84a49d9b3e58, thanks!

--ryan.

On 2017-06-12 06:39:00 +0000, Martin Gerhardy wrote:

Thanks a lot - one part was missed - GLOB POWER_SOURCES should be used as variable names. (Not sure whether this is a must have - but it's the cleaner way)

On 2017-06-12 06:40:27 +0000, Martin Gerhardy wrote:

I meant shouldn't - GLOB HAPTIC_SOURCES should be used - the patch was just recorded in the wrong direction. Sorry for the confusion.

On 2017-06-12 23:36:12 +0000, Sam Lantinga wrote:

Fixed, thanks!
https://hg.libsdl.org/SDL/rev/5cf754a84eb7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant