Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android cmake build errors #2468

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 0 comments
Closed

Android cmake build errors #2468

SDLBugzilla opened this issue Feb 11, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: HG 2.0
Reported for operating system, platform: Android (All), All

Comments on the original bug report:

On 2017-06-08 19:16:17 +0000, Olli Kallioinen wrote:

Created attachment 2756
Fix for this issue

I made a fix earlier for these android build issues:
https://bugzilla.libsdl.org/show_bug.cgi?id=3509
https://bugzilla.libsdl.org/show_bug.cgi?id=3267

But with further testing I came across a couple more build issues:

  • Some parts of SDL were were not being built (SDL_TIMERS and SDL_LOADSO).
  • threading was not working
  • Android mips and arm64 builds were failing

A patch that fixes these is attached.

The more obscure ABIs were not building because there is no hardware specific spinlock implementation for those. To be able to build for all available android ABIs I Enabled by default checking for GCC_ATOMICS also on clang. This is the only part of the changes that affects other platforms than Android too. Is this a good default for other platforms or was there some reason for not using builtin atomics by default when using clang?

On 2017-06-08 19:19:23 +0000, Olli Kallioinen wrote:

Created attachment 2757
Fix for this issue

On 2017-08-09 05:34:25 +0000, Ryan C. Gordon wrote:

(Sorry if you get a lot of copies of this email, we're touching dozens of bug reports right now.)

Tagging a bunch of bugs as target-2.0.6.

This means we're in the final stretch for an official SDL 2.0.6 release! These are the bugs we really want to fix before shipping if humanly possible.

That being said, we don't promise to fix them because of this tag, we just want to make sure we don't forget to deal with them before we bless a final 2.0.6 release, and generally be organized about what we're aiming to ship. After some debate, we might just remove this tag again and deal with it for a later release.

Hopefully you'll hear more about this bug soon. If you have more information (including "this got fixed at some point, nevermind"), we would love to have you come add more information to the bug report when you have a moment.

Thanks!
--ryan.

On 2017-08-09 23:22:06 +0000, Sam Lantinga wrote:

Patch applied, thanks!
https://hg.libsdl.org/SDL/rev/4ed2e42b7497

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant