Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL_DisplayMode struct should store refresh_rate as a numerator and denominator in addition to int #2467

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 2 comments
Milestone

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

Reported in version: HG 2.1
Reported for operating system, platform: Windows 10, x86_64

Comments on the original bug report:

On 2017-06-08 13:39:42 +0000, wrote:

To be able to support target phys/sim timestep to be some factor of actual monitor refresh rate (1x, 2x, 0.5x). You can have monitors that are 59.94hz for example (see link below) that will report 59hz here. Not a HUGE deal but it'd be nice to have that precision.

https://support.microsoft.com/en-us/help/2006076/screen-refresh-rate-in-windows-does-not-apply-the-user-selected-settings-on-monitors-tvs-that-report-specific-tv-compatible-timings

On 2017-08-11 18:12:33 +0000, Sam Lantinga wrote:

Yes, this is a good change for SDL 2.1

@slouken slouken removed the bug label May 11, 2022
@icculus icculus added this to the 3.0 milestone Aug 23, 2022
@1bsyl
Copy link
Contributor

1bsyl commented Dec 29, 2022

from @slouken

I think we should add refresh numerator and denominator instead of changing the precision to a double. We can leave the int refresh rate as well, for programs that don't need fractional precision, just rounded as it is now

@slouken slouken modified the milestones: 3.x, 3.2.0 Dec 29, 2022
@slouken slouken changed the title SDL_DisplayMode struct should store refresh_rate as a double SDL_DisplayMode struct should store refresh_rate as a numerator and denominator in addition to int Dec 29, 2022
@1bsyl
Copy link
Contributor

1bsyl commented Jan 4, 2023

was fixed

@1bsyl 1bsyl closed this as completed Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants