This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

• The patch itself, pretty tiny! (swy-implement-parented-message-boxes-on-windows.patch, text/plain, 2017-05-13 00:50:07 +0000, 1100 bytes)

Reported in version: HG 2.0
Reported for operating system, platform: Windows (All), All

Comments on the original bug report:

On 2017-05-13 00:50:07 +0000, Ismael Ferreras Morezuelas (Swyter) wrote:

Created attachment 2733
The patch itself, pretty tiny!

Hi there! I have been meaning to fix this one for a while.

The fact that at the moment clicking a crashed window hides the messagebox with all the handy information it has to offer about the cause of the problem has probably caused additional rage for more than one, I bet.

This three-line patch finds if the current messagebox has an assigned parent window and if that's the case grabs its window handle and uses it on dialog creation. Windows will then give exclusive focus to that new dialog whenever someone clicks over the crashed window in despair. So that we can at least fail with style.

Windows-only at the moment, even if I believe that the Linux version has similar problems. Maybe I can get around and fix that one after getting this patch through.

Let me know what you think! I can rework it a bit more, as I don't want to ship a forked version!

PS: SDL2 is pretty neat and straightforward to use. Thanks so much! :)

On 2017-05-27 04:33:36 +0000, Ryan C. Gordon wrote:

This patch is now https://hg.libsdl.org/SDL/rev/c5346d5c3c79, thanks!

--ryan.