We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 365 - SDL_WM_SetCaption() cannot handle Japanese(and maybe other languages) on Windows
Summary: SDL_WM_SetCaption() cannot handle Japanese(and maybe other languages) on Windows
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: video (show other bugs)
Version: 1.2.11
Hardware: x86 Windows (All)
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-17 07:06 UTC by aki.
Modified: 2007-02-16 01:21 UTC (History)
0 users

See Also:

Attachments
Proposed patch to handle Unicode... (1.61 KB, patch)
2007-02-13 04:54 UTC, Ryan C. Gordon 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description aki. 2006-11-17 07:06:16 UTC 
Hello,

When Japanese is given to SDL_WM_SetCaption() on Windows, it garbles.

WinAPI receives string corresponding to the code page of the system.
Therefore, I think that it should use such as following codes instead of SDL_iconv_utf8_latin1():

char *SDL_iconv_utf8_acp(char *in) {
    Uint16 *lpsz = SDL_iconv_utf8_ucs2(in);
    size_t len = WideCharToMultiByte(CP_ACP, 0, lpsz, -1, NULL, 0, NULL, NULL);
    char *out = SDL_malloc(len + 1);
    WideCharToMultiByte(CP_ACP, 0, lpsz, -1, out, len, NULL, NULL);
    SDL_free(lpsz);
    return out;
}

Regards,
aki. (c@tqzh.tk)
Comment 1 Ryan C. Gordon 2007-02-13 04:54:06 UTC 
Created attachment 189 [details]
Proposed patch to handle Unicode...


Here's a proposed patch...it is untested and may not even compile, yet.

It will see if SetWindowTextW() is available in kernel32.dll (as it will be on WinNT, WinXP, Win2000 and Vista), and if so, it feeds the ucs-2 string to it. This will allow, for example, Japanese characters to be used in the titlebar on a WinXP box that uses a Russian codepage.

If SetWindowsTextW() isn't available (Win95, Win98, WinME), then it will use WideCharToMultiByte(CP_ACP, ...) as originally proposed. This will not necessarily work everywhere, but it will probably work in most real life scenarios, and definitely better than assuming a latin1 codepage as we currently do.

If there are no objections, I'll commit this patch once I've had a chance to compile and test it on Windows.

--ryan.
Comment 2 Ryan C. Gordon 2007-02-16 01:21:47 UTC 
Fixed in svn revision #2985 for the 1.2 branch.

--ryan.